[dotnot] change default behavior for Select class with disabled elements

titusfortner · titusfortner · commit fa85effa0e77 · 2022-09-11T18:58:56.000-05:00
diff --git a/dotnet/src/support/UI/SelectElement.cs b/dotnet/src/support/UI/SelectElement.cs
@@ -44,6 +44,11 @@ public SelectElement(IWebElement element)
                 throw new ArgumentNullException(nameof(element), "element cannot be null");
             }
 
+            if (!element.Enabled)
+            {
+                throw new InvalidOperationException("Select element is disabled and may not be used.");
+            }
+
             string tagName = element.TagName;
 
             if (string.IsNullOrEmpty(tagName) || string.Compare(tagName, "select", StringComparison.OrdinalIgnoreCase) != 0)
@@ -446,6 +451,10 @@ private static string GetLongestSubstringWithoutSpace(string s)
 
         private static void SetSelected(IWebElement option, bool select)
         {
+            if (select && !option.Enabled) {
+                throw new InvalidOperationException("You may not select a disabled option");
+            }
+
             bool isSelected = option.Selected;
             if ((!isSelected && select) || (isSelected && !select))
             {
diff --git a/dotnet/test/support/UI/SelectBrowserTests.cs b/dotnet/test/support/UI/SelectBrowserTests.cs
@@ -34,6 +34,13 @@ public void ShouldThrowAnExceptionIfTheElementIsNotASelectElement()
             Assert.Throws<UnexpectedTagNameException>(() => { SelectElement elementWrapper = new SelectElement(element); });
         }
 
+        [Test]
+        public void ShouldThrowAnExceptionIfTheElementIsNotEnabled()
+        {
+            IWebElement element = driver.FindElement(By.Name("no-select"));
+            Assert.Throws<InvalidOperationException>(() => { SelectElement elementWrapper = new SelectElement(element); });
+        }
+
         [Test]
         public void ShouldIndicateThatASelectCanSupportMultipleOptions()
         {
@@ -141,7 +148,7 @@ public void ShouldReturnFirstSelectedOption()
 
         // [Test]
         // [ExpectedException(typeof(NoSuchElementException))]
-        // The .NET bindings do not have a "FirstSelectedOption" property, 
+        // The .NET bindings do not have a "FirstSelectedOption" property,
         // and no one has asked for it to this point. Given that, this test
         // is not a valid test.
         public void ShouldThrowANoSuchElementExceptionIfNothingIsSelected()
@@ -196,6 +203,14 @@ public void ShouldThrowExceptionOnSelectByVisibleTextIfOptionDoesNotExist()
             Assert.Throws<NoSuchElementException>(() => elementWrapper.SelectByText("not there"));
         }
 
+        [Test]
+        public void ShouldThrowExceptionOnSelectByVisibleTextIfOptionDisabled()
+        {
+            IWebElement element = driver.FindElement(By.Name("single_disabled"));
+            SelectElement elementWrapper = new SelectElement(element);
+            Assert.Throws<NoSuchElementException>(() => elementWrapper.SelectByText("Disabled"));
+        }
+
         [Test]
         public void ShouldAllowOptionsToBeSelectedByIndex()
         {
@@ -214,6 +229,14 @@ public void ShouldThrowExceptionOnSelectByIndexIfOptionDoesNotExist()
             Assert.Throws<NoSuchElementException>(() => elementWrapper.SelectByIndex(10));
         }
 
+        [Test]
+        public void ShouldThrowExceptionOnSelectByIndexIfOptionDisabled()
+        {
+            IWebElement element = driver.FindElement(By.Name("single_disabled"));
+            SelectElement elementWrapper = new SelectElement(element);
+            Assert.Throws<NoSuchElementException>(() => elementWrapper.SelectByIndex(1));
+        }
+
         [Test]
         public void ShouldAllowOptionsToBeSelectedByReturnedValue()
         {
@@ -232,6 +255,14 @@ public void ShouldThrowExceptionOnSelectByReturnedValueIfOptionDoesNotExist()
             Assert.Throws<NoSuchElementException>(() => elementWrapper.SelectByValue("not there"));
         }
 
+        [Test]
+        public void ShouldThrowExceptionOnSelectByReturnedValueIfOptionDisabled()
+        {
+            IWebElement element = driver.FindElement(By.Name("single_disabled"));
+            SelectElement elementWrapper = new SelectElement(element);
+            Assert.Throws<NoSuchElementException>(() => elementWrapper.SelectByValue("disabled"));
+        }
+
         [Test]
         public void ShouldAllowUserToDeselectAllWhenSelectSupportsMultipleSelections()
         {
diff --git a/dotnet/test/support/UI/SelectTests.cs b/dotnet/test/support/UI/SelectTests.cs
@@ -25,6 +25,13 @@ public void ThrowUnexpectedTagNameExceptionWhenNotSelectTag()
             Assert.Throws<UnexpectedTagNameException>(() => new SelectElement(webElement.Object));
         }
 
+        [Test]
+        public void ThrowUnexpectedTagNameExceptionWhenNotEnabled()
+        {
+            webElement.SetupGet<bool>(_ => _.Enabled).Returns(false);
+            Assert.Throws<InvalidOperationException>(() => new SelectElement(webElement.Object));
+        }
+
         [Test]
         public void CanCreateNewInstanceOfSelectWithNormalSelectElement()
         {

Original file line number	Diff line number	Diff line change
`@@ -44,6 +44,11 @@ public SelectElement(IWebElement element)`
`44`	`44`	`throw new ArgumentNullException(nameof(element), "element cannot be null");`
`45`	`45`	`}`
`46`	`46`
	`47`	`+ if (!element.Enabled)`
	`48`	`+ {`
	`49`	`+ throw new InvalidOperationException("Select element is disabled and may not be used.");`
	`50`	`+ }`
	`51`	`+`
`47`	`52`	`string tagName = element.TagName;`
`48`	`53`
`49`	`54`	`if (string.IsNullOrEmpty(tagName) \|\| string.Compare(tagName, "select", StringComparison.OrdinalIgnoreCase) != 0)`
`@@ -446,6 +451,10 @@ private static string GetLongestSubstringWithoutSpace(string s)`
`446`	`451`
`447`	`452`	`private static void SetSelected(IWebElement option, bool select)`
`448`	`453`	`{`
	`454`	`+ if (select && !option.Enabled) {`
	`455`	`+ throw new InvalidOperationException("You may not select a disabled option");`
	`456`	`+ }`
	`457`	`+`
`449`	`458`	`bool isSelected = option.Selected;`
`450`	`459`	`if ((!isSelected && select) \|\| (isSelected && !select))`
`451`	`460`	`{`
Original file line number	Diff line number	Diff line change
`@@ -25,6 +25,13 @@ public void ThrowUnexpectedTagNameExceptionWhenNotSelectTag()`
`25`	`25`	`Assert.Throws<UnexpectedTagNameException>(() => new SelectElement(webElement.Object));`
`26`	`26`	`}`
`27`	`27`
	`28`	`+ [Test]`
	`29`	`+ public void ThrowUnexpectedTagNameExceptionWhenNotEnabled()`
	`30`	`+ {`
	`31`	`+ webElement.SetupGet<bool>(_ => _.Enabled).Returns(false);`
	`32`	`+ Assert.Throws<InvalidOperationException>(() => new SelectElement(webElement.Object));`
	`33`	`+ }`
	`34`	`+`
`28`	`35`	`[Test]`
`29`	`36`	`public void CanCreateNewInstanceOfSelectWithNormalSelectElement()`
`30`	`37`	`{`