Skip to content

Commit f950543

Browse files
committed
[java] Moving few tests medium -> large, so they get executed
1 parent 4645f76 commit f950543

9 files changed

Lines changed: 27 additions & 40 deletions

File tree

java/test/org/openqa/selenium/chromium/BUILD.bazel

Lines changed: 1 addition & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ LARGE_TESTS = [
77

88
java_selenium_test_suite(
99
name = "large-tests",
10+
size = "large",
1011
srcs = LARGE_TESTS,
1112
browsers = [
1213
"chrome",
@@ -20,23 +21,3 @@ java_selenium_test_suite(
2021
artifact("org.assertj:assertj-core"),
2122
],
2223
)
23-
24-
java_test_suite(
25-
name = "small-tests",
26-
size = "small",
27-
srcs = glob(
28-
["*.java"],
29-
exclude = LARGE_TESTS,
30-
),
31-
deps = [
32-
"//java/src/org/openqa/selenium:core",
33-
"//java/src/org/openqa/selenium/chrome",
34-
"//java/src/org/openqa/selenium/chromium",
35-
"//java/src/org/openqa/selenium/edge",
36-
"//java/src/org/openqa/selenium/json",
37-
"//java/test/org/openqa/selenium/testing:annotations",
38-
"//java/test/org/openqa/selenium/testing:test-base",
39-
artifact("junit:junit"),
40-
artifact("org.assertj:assertj-core"),
41-
],
42-
)

java/test/org/openqa/selenium/environment/BUILD.bazel

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -102,12 +102,15 @@ java_library(
102102
firefox = BROWSERS["firefox"]
103103

104104
java_test_suite(
105-
name = "MediumTests",
106-
size = "medium",
105+
name = "LargeTests",
106+
size = "large",
107107
srcs = glob(["**/*Test.java"]),
108108
data = firefox["data"],
109109
jvm_flags = firefox["jvm_flags"],
110-
tags = firefox["tags"],
110+
tags = [
111+
"selenium-remote",
112+
"firefox",
113+
] + firefox["tags"],
111114
deps = [
112115
":environment",
113116
":test-base",

java/test/org/openqa/selenium/grid/gridui/BUILD.bazel

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ load("@rules_jvm_external//:defs.bzl", "artifact")
22
load("//java:defs.bzl", "java_selenium_test_suite")
33

44
java_selenium_test_suite(
5-
name = "medium-tests",
6-
size = "medium",
5+
name = "large-tests",
6+
size = "large",
77
srcs = glob(["*.java"]),
88
browsers = [
99
"chrome",

java/test/org/openqa/selenium/mobile/BUILD.bazel

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,12 @@ load("@rules_jvm_external//:defs.bzl", "artifact")
22
load("//java:defs.bzl", "java_selenium_test_suite")
33

44
java_selenium_test_suite(
5-
name = "medium-tests",
6-
size = "medium",
5+
name = "large-tests",
6+
size = "large",
77
srcs = glob(["*.java"]),
8+
browsers = [
9+
"firefox",
10+
],
811
deps = [
912
"//java/src/org/openqa/selenium/remote",
1013
"//java/test/org/openqa/selenium/testing:annotations",

java/test/org/openqa/selenium/mobile/NetworkConnectionTest.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,6 @@
1717

1818
package org.openqa.selenium.mobile;
1919

20-
import static org.assertj.core.api.Assertions.assertThat;
21-
import static org.openqa.selenium.testing.drivers.Browser.CHROME;
22-
import static org.openqa.selenium.testing.drivers.Browser.EDGE;
23-
2420
import org.junit.Assume;
2521
import org.junit.Before;
2622
import org.junit.Test;
@@ -29,6 +25,10 @@
2925
import org.openqa.selenium.testing.JUnit4TestBase;
3026
import org.openqa.selenium.testing.NotYetImplemented;
3127

28+
import static org.assertj.core.api.Assertions.assertThat;
29+
import static org.openqa.selenium.testing.drivers.Browser.CHROME;
30+
import static org.openqa.selenium.testing.drivers.Browser.EDGE;
31+
3232
public class NetworkConnectionTest extends JUnit4TestBase {
3333

3434
private NetworkConnection networkConnectionDriver;
@@ -45,7 +45,7 @@ public void setUp() {
4545
@NotYetImplemented(EDGE)
4646
public void testToggleAirplaneMode() {
4747
NetworkConnection.ConnectionType current = networkConnectionDriver.getNetworkConnection();
48-
NetworkConnection.ConnectionType modified = null;
48+
NetworkConnection.ConnectionType modified;
4949
if (current.isAirplaneMode()) {
5050
modified = networkConnectionDriver.setNetworkConnection(NetworkConnection.ConnectionType.ALL);
5151
} else {

java/test/org/openqa/selenium/server/htmlrunner/BUILD.bazel

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ load("//java/private:selenium_test.bzl", "BROWSERS")
55
firefox = BROWSERS["firefox"]
66

77
java_test_suite(
8-
name = "MediumTests",
9-
size = "medium",
8+
name = "LargeTests",
9+
size = "large",
1010
srcs = glob(["*.java"]),
1111
data = firefox["data"],
1212
jvm_flags = firefox["jvm_flags"] + [

java/test/org/openqa/selenium/support/locators/BUILD.bazel

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ load("@rules_jvm_external//:defs.bzl", "artifact")
22
load("//java:defs.bzl", "java_selenium_test_suite")
33

44
java_selenium_test_suite(
5-
name = "MediumTests",
6-
size = "medium",
5+
name = "LargeTests",
6+
size = "large",
77
srcs = glob(["*Test.java"]),
88
browsers = ["chrome"],
99
javacopts = [

java/test/org/openqa/selenium/support/pagefactory/BUILD.bazel

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ java_test_suite(
2727
)
2828

2929
java_selenium_test_suite(
30-
name = "MediumTests",
31-
size = "medium",
30+
name = "LargeTests",
31+
size = "large",
3232
srcs = MEDIUM_TESTS,
3333
browsers = ["firefox"],
3434
deps = [

java/test/org/openqa/selenium/support/ui/BUILD.bazel

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ java_test_suite(
3535
)
3636

3737
java_selenium_test_suite(
38-
name = "MediumTests",
39-
size = "medium",
38+
name = "LargeTests",
39+
size = "large",
4040
srcs = LARGE_TESTS,
4141
browsers = [
4242
"firefox",

0 commit comments

Comments
 (0)