[java] make external modules static (#12294)

joerg1985 · diemol · web-flow · commit f2d842754c70 · 2023-07-31T13:42:44.000+02:00
Co-authored-by: Diego Molina &lt;diemol@users.noreply.github.com&gt;
diff --git a/java/src/dev/selenium/tools/modules/ModuleGenerator.java b/java/src/dev/selenium/tools/modules/ModuleGenerator.java
@@ -21,6 +21,7 @@
 import static net.bytebuddy.jar.asm.Opcodes.ACC_MANDATED;
 import static net.bytebuddy.jar.asm.Opcodes.ACC_MODULE;
 import static net.bytebuddy.jar.asm.Opcodes.ACC_OPEN;
+import static net.bytebuddy.jar.asm.Opcodes.ACC_STATIC_PHASE;
 import static net.bytebuddy.jar.asm.Opcodes.ACC_TRANSITIVE;
 import static net.bytebuddy.jar.asm.Opcodes.ASM9;
 
@@ -491,7 +492,13 @@ public void visit(ModuleRequiresDirective n, Void arg) {
         // name. Therefore, the 'processed.' prefix added by bazel must be removed to get the name.
         name = name.substring(10);
       }
-      byteBuddyVisitor.visitRequire(name, getByteBuddyModifier(n.getModifiers()), null);
+      int modifiers = getByteBuddyModifier(n.getModifiers());
+      if (!name.startsWith("org.seleniumhq.selenium.") && !name.startsWith("java.")) {
+        // Some people like to exclude jars from the classpath. To allow this we need to make these modules static,
+        // otherwise a 'module not found' error while compiling their code would be the consequence.
+        modifiers |= ACC_STATIC_PHASE;
+      }
+      byteBuddyVisitor.visitRequire(name, modifiers, null);
     }
 
     @Override
@@ -530,8 +537,11 @@ private int getByteBuddyModifier(NodeList<Modifier> modifiers) {
       return modifiers.stream()
           .mapToInt(
               mod -> {
-                if (mod.getKeyword() == Modifier.Keyword.TRANSITIVE) {
-                  return ACC_TRANSITIVE;
+                switch (mod.getKeyword()) {
+                  case STATIC:
+                    return ACC_STATIC_PHASE;
+                  case TRANSITIVE:
+                    return ACC_TRANSITIVE;
                 }
                 throw new RuntimeException("Unknown modifier: " + mod);
               })
