[rust] Minor smell-fix reading mutable config

bonigarcia · bonigarcia · commit f0da49be7258 · 2023-07-20T13:06:36.000+02:00
diff --git a/rust/src/lib.rs b/rust/src/lib.rs
@@ -443,17 +443,15 @@ pub trait SeleniumManager {
     }
 
     fn set_os(&mut self, os: String) {
-        let mut config = self.get_config_mut();
-        config.os = os;
+        self.get_config_mut().os = os;
     }
 
     fn get_arch(&self) -> &str {
         self.get_config().arch.as_str()
     }
 
     fn set_arch(&mut self, arch: String) {
-        let mut config = self.get_config_mut();
-        config.arch = arch;
+        self.get_config_mut().arch = arch;
     }
 
     fn get_browser_version(&self) -> &str {
@@ -467,8 +465,7 @@ pub trait SeleniumManager {
 
     fn set_browser_version(&mut self, browser_version: String) {
         if !browser_version.is_empty() {
-            let mut config = self.get_config_mut();
-            config.browser_version = browser_version;
+            self.get_config_mut().browser_version = browser_version;
         }
     }
 
@@ -483,8 +480,7 @@ pub trait SeleniumManager {
 
     fn set_driver_version(&mut self, driver_version: String) {
         if !driver_version.is_empty() {
-            let mut config = self.get_config_mut();
-            config.driver_version = driver_version;
+            self.get_config_mut().driver_version = driver_version;
         }
     }
 
@@ -510,8 +506,7 @@ pub trait SeleniumManager {
 
     fn set_browser_path(&mut self, browser_path: String) {
         if !browser_path.is_empty() {
-            let mut config = self.get_config_mut();
-            config.browser_path = browser_path;
+            self.get_config_mut().browser_path = browser_path;
         }
     }
 
@@ -522,8 +517,7 @@ pub trait SeleniumManager {
     fn set_proxy(&mut self, proxy: String) -> Result<(), Box<dyn Error>> {
         if !proxy.is_empty() && !self.is_offline() {
             self.get_logger().debug(format!("Using proxy: {}", &proxy));
-            let mut config = self.get_config_mut();
-            config.proxy = proxy;
+            self.get_config_mut().proxy = proxy;
             self.update_http_client()?;
         }
         Ok(())
@@ -535,8 +529,7 @@ pub trait SeleniumManager {
 
     fn set_timeout(&mut self, timeout: u64) -> Result<(), Box<dyn Error>> {
         if timeout != REQUEST_TIMEOUT_SEC {
-            let mut config = self.get_config_mut();
-            config.timeout = timeout;
+            self.get_config_mut().timeout = timeout;
             self.get_logger()
                 .debug(format!("Using timeout of {} seconds", timeout));
             self.update_http_client()?;

Original file line number	Diff line number	Diff line change
`@@ -443,17 +443,15 @@ pub trait SeleniumManager {`
`443`	`443`	`}`
`444`	`444`
`445`	`445`	`fn set_os(&mut self, os: String) {`
`446`		`- let mut config = self.get_config_mut();`
`447`		`- config.os = os;`
	`446`	`+ self.get_config_mut().os = os;`
`448`	`447`	`}`
`449`	`448`
`450`	`449`	`fn get_arch(&self) -> &str {`
`451`	`450`	`self.get_config().arch.as_str()`
`452`	`451`	`}`
`453`	`452`
`454`	`453`	`fn set_arch(&mut self, arch: String) {`
`455`		`- let mut config = self.get_config_mut();`
`456`		`- config.arch = arch;`
	`454`	`+ self.get_config_mut().arch = arch;`
`457`	`455`	`}`
`458`	`456`
`459`	`457`	`fn get_browser_version(&self) -> &str {`
`@@ -467,8 +465,7 @@ pub trait SeleniumManager {`
`467`	`465`
`468`	`466`	`fn set_browser_version(&mut self, browser_version: String) {`
`469`	`467`	`if !browser_version.is_empty() {`
`470`		`- let mut config = self.get_config_mut();`
`471`		`- config.browser_version = browser_version;`
	`468`	`+ self.get_config_mut().browser_version = browser_version;`
`472`	`469`	`}`
`473`	`470`	`}`
`474`	`471`
`@@ -483,8 +480,7 @@ pub trait SeleniumManager {`
`483`	`480`
`484`	`481`	`fn set_driver_version(&mut self, driver_version: String) {`
`485`	`482`	`if !driver_version.is_empty() {`
`486`		`- let mut config = self.get_config_mut();`
`487`		`- config.driver_version = driver_version;`
	`483`	`+ self.get_config_mut().driver_version = driver_version;`
`488`	`484`	`}`
`489`	`485`	`}`
`490`	`486`
`@@ -510,8 +506,7 @@ pub trait SeleniumManager {`
`510`	`506`
`511`	`507`	`fn set_browser_path(&mut self, browser_path: String) {`
`512`	`508`	`if !browser_path.is_empty() {`
`513`		`- let mut config = self.get_config_mut();`
`514`		`- config.browser_path = browser_path;`
	`509`	`+ self.get_config_mut().browser_path = browser_path;`
`515`	`510`	`}`
`516`	`511`	`}`
`517`	`512`
`@@ -522,8 +517,7 @@ pub trait SeleniumManager {`
`522`	`517`	`fn set_proxy(&mut self, proxy: String) -> Result<(), Box<dyn Error>> {`
`523`	`518`	`if !proxy.is_empty() && !self.is_offline() {`
`524`	`519`	`self.get_logger().debug(format!("Using proxy: {}", &proxy));`
`525`		`- let mut config = self.get_config_mut();`
`526`		`- config.proxy = proxy;`
	`520`	`+ self.get_config_mut().proxy = proxy;`
`527`	`521`	`self.update_http_client()?;`
`528`	`522`	`}`
`529`	`523`	`Ok(())`
`@@ -535,8 +529,7 @@ pub trait SeleniumManager {`
`535`	`529`
`536`	`530`	`fn set_timeout(&mut self, timeout: u64) -> Result<(), Box<dyn Error>> {`
`537`	`531`	`if timeout != REQUEST_TIMEOUT_SEC {`
`538`		`- let mut config = self.get_config_mut();`
`539`		`- config.timeout = timeout;`
	`532`	`+ self.get_config_mut().timeout = timeout;`
`540`	`533`	`self.get_logger()`
`541`	`534`	`.debug(format!("Using timeout of {} seconds", timeout));`
`542`	`535`	`self.update_http_client()?;`