[rb] Looks like I added comments that this was deprecated 4 years ago, but never actually added deprecation warnings to the code

titusfortner · titusfortner · commit ebe1ec1ffc60 · 2022-12-12T07:44:51.000-08:00
Probably fine to just delete all of this, but I'll mark it deprecated to be safe
diff --git a/rb/lib/selenium/webdriver/chrome/service.rb b/rb/lib/selenium/webdriver/chrome/service.rb
@@ -32,7 +32,6 @@ class Service < WebDriver::Service
 
         private
 
-        # NOTE: This processing is deprecated
         def extract_service_args(driver_opts)
           driver_args = super
           driver_opts = driver_opts.dup
diff --git a/rb/lib/selenium/webdriver/common/service.rb b/rb/lib/selenium/webdriver/common/service.rb
@@ -90,6 +90,9 @@ def shutdown_supported
       protected
 
       def extract_service_args(driver_opts)
+        WebDriver.logger.deprecate("initializing Service class with :args using Hash",
+                                   ":args parameter with an Array of String values",
+                                   id: :driver_opts)
         driver_opts.key?(:args) ? driver_opts.delete(:args) : []
       end
 
diff --git a/rb/lib/selenium/webdriver/firefox/service.rb b/rb/lib/selenium/webdriver/firefox/service.rb
@@ -32,7 +32,6 @@ class Service < WebDriver::Service
 
         private
 
-        # NOTE: This processing is deprecated
         def extract_service_args(driver_opts)
           driver_args = super
           driver_opts = driver_opts.dup
diff --git a/rb/lib/selenium/webdriver/ie/service.rb b/rb/lib/selenium/webdriver/ie/service.rb
@@ -32,7 +32,6 @@ class Service < WebDriver::Service
 
         private
 
-        # NOTE: This processing is deprecated
         def extract_service_args(driver_opts)
           driver_args = super
           driver_opts = driver_opts.dup
diff --git a/rb/spec/unit/selenium/webdriver/chrome/service_spec.rb b/rb/spec/unit/selenium/webdriver/chrome/service_spec.rb
@@ -88,14 +88,15 @@ module WebDriver
           expect(service.extra_args).to eq ['--foo', '--bar']
         end
 
-        # This is deprecated behavior
         it 'uses args when passed in as a Hash' do
           allow(Platform).to receive(:find_binary).and_return(service_path)
 
-          service = Service.chrome(args: {log_path: '/path/to/log',
-                                          verbose: true})
+          expect {
+            service = Service.chrome(args: {log_path: '/path/to/log',
+                                            verbose: true})
 
-          expect(service.extra_args).to eq ['--log-path=/path/to/log', '--verbose']
+            expect(service.extra_args).to eq ['--log-path=/path/to/log', '--verbose']
+          }.to have_deprecated(:driver_opts)
         end
       end
 
diff --git a/rb/spec/unit/selenium/webdriver/edge/service_spec.rb b/rb/spec/unit/selenium/webdriver/edge/service_spec.rb
@@ -95,10 +95,12 @@ module WebDriver
         it 'uses args when passed in as a Hash' do
           allow(Platform).to receive(:find_binary).and_return(service_path)
 
-          service = Service.edge(args: {log_path: '/path/to/log',
-                                        verbose: true})
+          expect {
+            service = Service.edge(args: {log_path: '/path/to/log',
+                                          verbose: true})
 
-          expect(service.extra_args).to eq ['--log-path=/path/to/log', '--verbose']
+            expect(service.extra_args).to eq ['--log-path=/path/to/log', '--verbose']
+          }.to have_deprecated(:driver_opts)
         end
       end
 
diff --git a/rb/spec/unit/selenium/webdriver/firefox/service_spec.rb b/rb/spec/unit/selenium/webdriver/firefox/service_spec.rb
@@ -84,14 +84,15 @@ module WebDriver
           expect(service.extra_args).to eq ['--foo', '--bar']
         end
 
-        # This is deprecated behavior
         it 'uses args when passed in as a Hash' do
           allow(Platform).to receive(:find_binary).and_return(service_path)
 
-          service = Service.firefox(args: {log: '/path/to/log',
-                                           marionette_port: 4})
+          expect {
+            service = Service.firefox(args: {log: '/path/to/log',
+                                             marionette_port: 4})
 
-          expect(service.extra_args).to eq ['--log=/path/to/log', '--marionette-port=4']
+            expect(service.extra_args).to eq ['--log=/path/to/log', '--marionette-port=4']
+          }.to have_deprecated(:driver_opts)
         end
       end
 
diff --git a/rb/spec/unit/selenium/webdriver/ie/service_spec.rb b/rb/spec/unit/selenium/webdriver/ie/service_spec.rb
@@ -89,10 +89,12 @@ module WebDriver
         it 'uses args when passed in as a Hash' do
           allow(Platform).to receive(:find_binary).and_return(service_path)
 
-          service = Service.ie(args: {log_file: '/path/to/log',
-                                      silent: true})
+          expect {
+            service = Service.ie(args: {log_file: '/path/to/log',
+                                        silent: true})
 
-          expect(service.extra_args).to eq ['--log-file=/path/to/log', '--silent']
+            expect(service.extra_args).to eq ['--log-file=/path/to/log', '--silent']
+          }.to have_deprecated(:driver_opts)
         end
       end
 
