[dotnet] allow user to start service before creating driver (#12816)

titusfortner · web-flow · commit e66fbf532e10 · 2023-09-25T08:00:02.000-05:00
diff --git a/dotnet/src/webdriver/Chrome/ChromeDriverService.cs b/dotnet/src/webdriver/Chrome/ChromeDriverService.cs
@@ -41,6 +41,12 @@ private ChromeDriverService(string executablePath, string executableFileName, in
         {
         }
 
+        /// <inheritdoc />
+        protected override DriverOptions GetDefaultDriverOptions()
+        {
+            return new ChromeOptions();
+        }
+
         /// <summary>
         /// Creates a default instance of the ChromeDriverService.
         /// </summary>
diff --git a/dotnet/src/webdriver/DriverService.cs b/dotnet/src/webdriver/DriverService.cs
@@ -262,6 +262,11 @@ public void Start()
                 return;
             }
 
+            if (this.driverServicePath == null)
+            {
+                DriverFinder.FullPath(this.GetDefaultDriverOptions());
+            }
+
             this.driverServiceProcess = new Process();
             this.driverServiceProcess.StartInfo.FileName = Path.Combine(this.driverServicePath, this.driverServiceExecutableName);
             this.driverServiceProcess.StartInfo.Arguments = this.CommandLineArguments;
@@ -283,6 +288,12 @@ public void Start()
             }
         }
 
+        /// <summary>
+        /// The browser options instance that corresponds to the driver service
+        /// </summary>
+        /// <returns></returns>
+        protected abstract DriverOptions GetDefaultDriverOptions();
+
         /// <summary>
         /// Releases all resources associated with this <see cref="DriverService"/>.
         /// </summary>
diff --git a/dotnet/src/webdriver/Edge/EdgeDriverService.cs b/dotnet/src/webdriver/Edge/EdgeDriverService.cs
@@ -41,6 +41,12 @@ private EdgeDriverService(string executablePath, string executableFileName, int
         {
         }
 
+        /// <inheritdoc />
+        protected override DriverOptions GetDefaultDriverOptions()
+        {
+            return new EdgeOptions();
+        }
+
         /// <summary>
         /// Gets or sets a value indicating whether the service should use verbose logging.
         /// </summary>
diff --git a/dotnet/src/webdriver/Firefox/FirefoxDriverService.cs b/dotnet/src/webdriver/Firefox/FirefoxDriverService.cs
@@ -50,6 +50,12 @@ private FirefoxDriverService(string executablePath, string executableFileName, i
         {
         }
 
+        /// <inheritdoc />
+        protected override DriverOptions GetDefaultDriverOptions()
+        {
+            return new FirefoxOptions();
+        }
+
         /// <summary>
         /// Gets or sets the location of the Firefox binary executable.
         /// </summary>
diff --git a/dotnet/src/webdriver/IE/InternetExplorerDriverService.cs b/dotnet/src/webdriver/IE/InternetExplorerDriverService.cs
@@ -48,6 +48,12 @@ private InternetExplorerDriverService(string executablePath, string executableFi
         {
         }
 
+        /// <inheritdoc />
+        protected override DriverOptions GetDefaultDriverOptions()
+        {
+            return new InternetExplorerOptions();
+        }
+
         /// <summary>
         /// Gets or sets the value of the host adapter on which the IEDriverServer should listen for connections.
         /// </summary>
diff --git a/dotnet/src/webdriver/Safari/SafariDriverService.cs b/dotnet/src/webdriver/Safari/SafariDriverService.cs
@@ -46,6 +46,12 @@ private SafariDriverService(string executablePath, string executableFileName, in
         {
         }
 
+        /// <inheritdoc />
+        protected override DriverOptions GetDefaultDriverOptions()
+        {
+            return new SafariOptions();
+        }
+
         /// <summary>
         /// Gets or sets a value indicating whether to use the default open-source project
         /// dialect of the protocol instead of the default dialect compliant with the

Original file line number	Diff line number	Diff line change
`@@ -41,6 +41,12 @@ private ChromeDriverService(string executablePath, string executableFileName, in`
`41`	`41`	`{`
`42`	`42`	`}`
`43`	`43`
	`44`	`+ /// <inheritdoc />`
	`45`	`+ protected override DriverOptions GetDefaultDriverOptions()`
	`46`	`+ {`
	`47`	`+ return new ChromeOptions();`
	`48`	`+ }`
	`49`	`+`
`44`	`50`	`/// <summary>`
`45`	`51`	`/// Creates a default instance of the ChromeDriverService.`
`46`	`52`	`/// </summary>`
Original file line number	Diff line number	Diff line change
`@@ -41,6 +41,12 @@ private EdgeDriverService(string executablePath, string executableFileName, int`
`41`	`41`	`{`
`42`	`42`	`}`
`43`	`43`
	`44`	`+ /// <inheritdoc />`
	`45`	`+ protected override DriverOptions GetDefaultDriverOptions()`
	`46`	`+ {`
	`47`	`+ return new EdgeOptions();`
	`48`	`+ }`
	`49`	`+`
`44`	`50`	`/// <summary>`
`45`	`51`	`/// Gets or sets a value indicating whether the service should use verbose logging.`
`46`	`52`	`/// </summary>`
Original file line number	Diff line number	Diff line change
`@@ -50,6 +50,12 @@ private FirefoxDriverService(string executablePath, string executableFileName, i`
`50`	`50`	`{`
`51`	`51`	`}`
`52`	`52`
	`53`	`+ /// <inheritdoc />`
	`54`	`+ protected override DriverOptions GetDefaultDriverOptions()`
	`55`	`+ {`
	`56`	`+ return new FirefoxOptions();`
	`57`	`+ }`
	`58`	`+`
`53`	`59`	`/// <summary>`
`54`	`60`	`/// Gets or sets the location of the Firefox binary executable.`
`55`	`61`	`/// </summary>`
Original file line number	Diff line number	Diff line change
`@@ -48,6 +48,12 @@ private InternetExplorerDriverService(string executablePath, string executableFi`
`48`	`48`	`{`
`49`	`49`	`}`
`50`	`50`
	`51`	`+ /// <inheritdoc />`
	`52`	`+ protected override DriverOptions GetDefaultDriverOptions()`
	`53`	`+ {`
	`54`	`+ return new InternetExplorerOptions();`
	`55`	`+ }`
	`56`	`+`
`51`	`57`	`/// <summary>`
`52`	`58`	`/// Gets or sets the value of the host adapter on which the IEDriverServer should listen for connections.`
`53`	`59`	`/// </summary>`
Original file line number	Diff line number	Diff line change
`@@ -46,6 +46,12 @@ private SafariDriverService(string executablePath, string executableFileName, in`
`46`	`46`	`{`
`47`	`47`	`}`
`48`	`48`
	`49`	`+ /// <inheritdoc />`
	`50`	`+ protected override DriverOptions GetDefaultDriverOptions()`
	`51`	`+ {`
	`52`	`+ return new SafariOptions();`
	`53`	`+ }`
	`54`	`+`
`49`	`55`	`/// <summary>`
`50`	`56`	`/// Gets or sets a value indicating whether to use the default open-source project`
`51`	`57`	`/// dialect of the protocol instead of the default dialect compliant with the`