Skip to content

Commit db9fcdb

Browse files
harsha509harsha509
committed
[JS] Fix lint issues
1 parent 857240d commit db9fcdb

9 files changed

Lines changed: 97 additions & 68 deletions

File tree

‎javascript/node/selenium-webdriver/bidi/logEntries.js‎

Lines changed: 16 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -18,70 +18,73 @@
1818
'use strict'
1919

2020
class BaseLogEntry {
21-
constructor (level, text, timeStamp, stackTrace) {
21+
constructor(level, text, timeStamp, stackTrace) {
2222
this._level = level
2323
this._text = text
2424
this._timeStamp = timeStamp
2525
this._stackTrace = stackTrace
2626
}
2727

28-
get level () {
28+
get level() {
2929
return this._level
3030
}
3131

32-
get text () {
32+
get text() {
3333
return this._text
3434
}
3535

36-
get timeStamp () {
36+
get timeStamp() {
3737
return this._timeStamp
3838
}
3939

40-
get stackTrace () {
40+
get stackTrace() {
4141
return this._stackTrace
4242
}
4343
}
4444

4545
class GenericLogEntry extends BaseLogEntry {
46-
constructor (level, text, timeStamp, type, stackTrace) {
46+
constructor(level, text, timeStamp, type, stackTrace) {
4747
super(level, text, timeStamp, stackTrace)
4848
this._type = type
4949
}
5050

51-
get type () {
51+
get type() {
5252
return this._type
5353
}
5454
}
5555

5656
class ConsoleLogEntry extends GenericLogEntry {
57-
constructor (level, text, timeStamp, type, method, realm, args, stackTrace) {
57+
constructor(level, text, timeStamp, type, method, realm, args, stackTrace) {
5858
super(level, text, timeStamp, type, stackTrace)
5959
this._method = method
6060
this._realm = realm
6161
this._args = args
6262
}
6363

64-
get method () {
64+
get method() {
6565
return this._method
6666
}
6767

68-
get realm () {
68+
get realm() {
6969
return this._realm
7070
}
7171

72-
get args () {
72+
get args() {
7373
return this._args
7474
}
7575
}
7676

7777
class JavascriptLogEntry extends GenericLogEntry {
78-
constructor (level, text, timeStamp, type, stackTrace) {
78+
constructor(level, text, timeStamp, type, stackTrace) {
7979
super(level, text, timeStamp, type, stackTrace)
8080
}
8181
}
8282

8383
// PUBLIC API
8484

8585
module.exports = {
86-
BaseLogEntry, GenericLogEntry, ConsoleLogEntry, JavascriptLogEntry,
86+
BaseLogEntry,
87+
GenericLogEntry,
88+
ConsoleLogEntry,
89+
JavascriptLogEntry,
8790
}

‎javascript/node/selenium-webdriver/common/seleniumManager.js‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -81,12 +81,10 @@ function driverLocation(browser) {
8181
} catch (e) {
8282
error = e.toString()
8383
}
84-
throw new Error(
85-
`Error executing command with ${args}: ${error}`
86-
)
84+
throw new Error(`Error executing command with ${args}: ${error}`)
8785
}
8886

89-
for (const key in output.logs){
87+
for (const key in output.logs) {
9088
if (output.logs[key].level === 'WARN') {
9189
console.warn(`${output.logs[key].message}`)
9290
}

‎javascript/node/selenium-webdriver/http/index.js‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,8 @@ function getRequestOptions(aUrl) {
5454
options.search = null
5555
options.hash = null
5656
options.path = options.pathname
57-
options.hostname = options.hostname === 'localhost' ? '127.0.0.1' : options.hostname // To support Node 17 and above. Refer https://github.com/nodejs/node/issues/40702 for details.
57+
options.hostname =
58+
options.hostname === 'localhost' ? '127.0.0.1' : options.hostname // To support Node 17 and above. Refer https://github.com/nodejs/node/issues/40702 for details.
5859
return options
5960
}
6061

‎javascript/node/selenium-webdriver/lib/http.js‎

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,10 @@ function toExecuteAtomCommand(command, atom, name, ...params) {
189189

190190
return new cmd.Command(cmd.Name.EXECUTE_SCRIPT)
191191
.setParameter('sessionId', command.getParameter('sessionId'))
192-
.setParameter('script', `/* ${name} */return (${atom}).apply(null, arguments)`)
192+
.setParameter(
193+
'script',
194+
`/* ${name} */return (${atom}).apply(null, arguments)`
195+
)
193196
.setParameter(
194197
'args',
195198
params.map((param) => command.getParameter(param))
@@ -252,7 +255,12 @@ const W3C_COMMAND_MAP = new Map([
252255
[
253256
cmd.Name.FIND_ELEMENTS_RELATIVE,
254257
(cmd) => {
255-
return toExecuteAtomCommand(cmd, Atom.FIND_ELEMENTS, 'findElements', 'args')
258+
return toExecuteAtomCommand(
259+
cmd,
260+
Atom.FIND_ELEMENTS,
261+
'findElements',
262+
'args'
263+
)
256264
},
257265
],
258266
[
@@ -272,7 +280,13 @@ const W3C_COMMAND_MAP = new Map([
272280
[
273281
cmd.Name.GET_ELEMENT_ATTRIBUTE,
274282
(cmd) => {
275-
return toExecuteAtomCommand(cmd, Atom.GET_ATTRIBUTE, 'getAttribute', 'id', 'name')
283+
return toExecuteAtomCommand(
284+
cmd,
285+
Atom.GET_ATTRIBUTE,
286+
'getAttribute',
287+
'id',
288+
'name'
289+
)
276290
},
277291
],
278292
[

‎javascript/node/selenium-webdriver/lib/webdriver.js‎

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2252,11 +2252,13 @@ class Window {
22522252
*/
22532253
async getSize(windowHandle = 'current') {
22542254
if (windowHandle !== 'current') {
2255-
console.warn(`Only 'current' window is supported for W3C compatible browsers.`);
2255+
console.warn(
2256+
`Only 'current' window is supported for W3C compatible browsers.`
2257+
)
22562258
}
22572259

2258-
const rect = await this.getRect();
2259-
return {height: rect.height, width: rect.width};
2260+
const rect = await this.getRect()
2261+
return { height: rect.height, width: rect.width }
22602262
}
22612263

22622264
/**
@@ -2268,12 +2270,17 @@ class Window {
22682270
* @param windowHandle
22692271
* @returns {Promise<void>}
22702272
*/
2271-
async setSize({x = 0, y = 0, width = 0, height = 0}, windowHandle = 'current') {
2273+
async setSize(
2274+
{ x = 0, y = 0, width = 0, height = 0 },
2275+
windowHandle = 'current'
2276+
) {
22722277
if (windowHandle !== 'current') {
2273-
console.warn(`Only 'current' window is supported for W3C compatible browsers.`);
2278+
console.warn(
2279+
`Only 'current' window is supported for W3C compatible browsers.`
2280+
)
22742281
}
22752282

2276-
await this.setRect({x, y, width, height});
2283+
await this.setRect({ x, y, width, height })
22772284
}
22782285
}
22792286

‎javascript/node/selenium-webdriver/package.json‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
12
{
23
"name": "selenium-webdriver",
34
"version": "4.8.2",
@@ -41,7 +42,7 @@
4142
"sinon": "^15.0.3"
4243
},
4344
"scripts": {
44-
"lint": "eslint --ignore-pattern node_modules --ignore-pattern generator --fix --ext js lib/http.js \"**/*.js\"",
45+
"lint": "eslint --ignore-pattern node_modules --ignore-pattern generator --ext js lib/http.js \"**/*.js\"",
4546
"test": "npm run lint && mocha -t 600000 --recursive test",
4647
"test-jasmine": "bazel test //javascript/node/selenium-webdriver:tests"
4748
},

‎javascript/node/selenium-webdriver/remote/util.js‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,9 @@ function isSelenium3x(seleniumStandalonePath) {
5252
*/
5353
function formatSpawnArgs(seleniumStandalonePath, args) {
5454
if (isSelenium3x(seleniumStandalonePath)) {
55-
console.warn('Deprecation: Support for Standalone Server 3.x will be removed soon. Please update to version 4.x')
55+
console.warn(
56+
'Deprecation: Support for Standalone Server 3.x will be removed soon. Please update to version 4.x'
57+
)
5658
return args
5759
}
5860

‎javascript/node/selenium-webdriver/test/chrome/permission_test.js‎

Lines changed: 41 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -20,55 +20,61 @@
2020
const assert = require('assert')
2121
const chrome = require('../../chrome')
2222
const test = require('../../lib/test')
23-
const {ignore} = require("../../lib/test");
24-
const {Browser} = require("../../index");
23+
const { ignore } = require('../../lib/test')
24+
const { Browser } = require('../../index')
2525

2626
test.suite(
2727
function (env) {
2828
// Chrome unable to set "prompt" due to: https://bugs.chromium.org/p/chromedriver/issues/detail?id=4350
2929
describe('setPermission', () => {
30-
ignore(env.browsers(Browser.CHROME)).it('can set permission', async function () {
31-
const driver = await env.builder().build()
30+
ignore(env.browsers(Browser.CHROME)).it(
31+
'can set permission',
32+
async function () {
33+
const driver = await env.builder().build()
3234

33-
await driver.get(test.Pages.clicksPage)
35+
await driver.get(test.Pages.clicksPage)
3436

35-
await driver.setPermission('clipboard-read', 'prompt')
36-
assert.strictEqual(
37-
await checkPermission(driver, 'clipboard-read'),
38-
'prompt'
39-
)
37+
await driver.setPermission('clipboard-read', 'prompt')
38+
assert.strictEqual(
39+
await checkPermission(driver, 'clipboard-read'),
40+
'prompt'
41+
)
4042

41-
await driver.setPermission('clipboard-read', 'granted')
42-
assert.strictEqual(
43-
await checkPermission(driver, 'clipboard-read'),
44-
'granted'
45-
)
43+
await driver.setPermission('clipboard-read', 'granted')
44+
assert.strictEqual(
45+
await checkPermission(driver, 'clipboard-read'),
46+
'granted'
47+
)
4648

47-
await driver.quit()
48-
})
49+
await driver.quit()
50+
}
51+
)
4952

50-
ignore(env.browsers(Browser.CHROME)).it('can set permission in headless mode', async function () {
51-
const driver = await env
52-
.builder()
53-
.setChromeOptions(new chrome.Options().headless())
54-
.build()
53+
ignore(env.browsers(Browser.CHROME)).it(
54+
'can set permission in headless mode',
55+
async function () {
56+
const driver = await env
57+
.builder()
58+
.setChromeOptions(new chrome.Options().headless())
59+
.build()
5560

56-
await driver.get(test.Pages.clicksPage)
61+
await driver.get(test.Pages.clicksPage)
5762

58-
await driver.setPermission('clipboard-read', 'prompt')
59-
assert.strictEqual(
60-
await checkPermission(driver, 'clipboard-read'),
61-
'prompt'
62-
)
63+
await driver.setPermission('clipboard-read', 'prompt')
64+
assert.strictEqual(
65+
await checkPermission(driver, 'clipboard-read'),
66+
'prompt'
67+
)
6368

64-
await driver.setPermission('clipboard-read', 'granted')
65-
assert.strictEqual(
66-
await checkPermission(driver, 'clipboard-read'),
67-
'granted'
68-
)
69+
await driver.setPermission('clipboard-read', 'granted')
70+
assert.strictEqual(
71+
await checkPermission(driver, 'clipboard-read'),
72+
'granted'
73+
)
6974

70-
await driver.quit()
71-
})
75+
await driver.quit()
76+
}
77+
)
7278
})
7379
},
7480
{ browsers: ['chrome'] }

‎javascript/node/selenium-webdriver/test/select_test.js‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,7 @@
1919

2020
const assert = require('assert')
2121
const { Select, By } = require('..')
22-
const { Pages, ignore, suite } = require('../lib/test')
23-
const { Browser } = require('../index')
22+
const { Pages, suite } = require('../lib/test')
2423

2524
let singleSelectValues1 = {
2625
name: 'selectomatic',
@@ -47,8 +46,6 @@ let multiSelectValues2 = {
4746

4847
suite(
4948
function (env) {
50-
const browsers = (...args) => env.browsers(...args)
51-
5249
let driver
5350

5451
before(async function () {

0 commit comments

Comments
 (0)