[java] use a static class for ProxySelector #13622

joerg1985 · joerg1985 · commit db517766c1f3 · 2024-02-29T20:03:59.000+01:00
diff --git a/java/src/org/openqa/selenium/remote/http/jdk/JdkHttpClient.java b/java/src/org/openqa/selenium/remote/http/jdk/JdkHttpClient.java
@@ -135,24 +135,7 @@ protected PasswordAuthentication getPasswordAuthentication() {
 
     Proxy proxy = config.proxy();
     if (proxy != null) {
-      ProxySelector proxySelector =
-          new ProxySelector() {
-            @Override
-            public List<Proxy> select(URI uri) {
-              if (proxy == null) {
-                return List.of();
-              }
-              if (uri.getScheme().toLowerCase().startsWith("http")) {
-                return List.of(proxy);
-              }
-              return List.of();
-            }
-
-            @Override
-            public void connectFailed(URI uri, SocketAddress sa, IOException ioe) {
-              // Do nothing
-            }
-          };
+      ProxySelector proxySelector = new HttpProxySelector(proxy);
       builder = builder.proxy(proxySelector);
     }
 
@@ -488,4 +471,28 @@ public HttpClient createClient(ClientConfig config) {
       return new JdkHttpClient(config);
     }
   }
+
+  private static class HttpProxySelector extends ProxySelector {
+    private final Proxy proxy;
+
+    public HttpProxySelector(Proxy proxy) {
+      this.proxy = proxy;
+    }
+
+    @Override
+    public List<Proxy> select(URI uri) {
+      if (proxy == null) {
+        return List.of();
+      }
+      if (uri.getScheme().toLowerCase().startsWith("http")) {
+        return List.of(proxy);
+      }
+      return List.of();
+    }
+
+    @Override
+    public void connectFailed(URI uri, SocketAddress sa, IOException ioe) {
+      // Do nothing
+    }
+  }
 }
