Skip to content

Commit d8f3b4f

Browse files
committed
[java] Enabling Chrome typing tests
and adding Firefox Beta to the browser matrix
1 parent 2546c4a commit d8f3b4f

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

.github/workflows/java.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,8 @@ jobs:
110110
include:
111111
- browser: 'firefox'
112112
version: 'latest-devedition'
113+
- browser: 'firefox'
114+
version: 'latest-beta'
113115
steps:
114116
- name: Checkout source tree
115117
uses: actions/checkout@v2
@@ -164,6 +166,8 @@ jobs:
164166
include:
165167
- browser: 'firefox'
166168
version: 'latest-devedition'
169+
- browser: 'firefox'
170+
version: 'latest-beta'
167171
steps:
168172
- name: Checkout source tree
169173
uses: actions/checkout@v2

java/test/org/openqa/selenium/TypingTest.java

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
import static org.junit.Assume.assumeFalse;
2424
import static org.openqa.selenium.WaitingConditions.elementValueToEqual;
2525
import static org.openqa.selenium.testing.TestUtilities.getEffectivePlatform;
26-
import static org.openqa.selenium.testing.drivers.Browser.CHROME;
2726
import static org.openqa.selenium.testing.drivers.Browser.FIREFOX;
2827
import static org.openqa.selenium.testing.drivers.Browser.IE;
2928
import static org.openqa.selenium.testing.drivers.Browser.SAFARI;
@@ -428,7 +427,6 @@ public void testSpecialSpaceKeys() {
428427
@Test
429428
@NotYetImplemented(value = FIREFOX)
430429
@NotYetImplemented(value = SAFARI, reason = "Enters dot instead of comma")
431-
@Ignore(value = CHROME, reason = "https://bugs.chromium.org/p/chromedriver/issues/detail?id=3999")
432430
public void testNumberPadKeys() {
433431
driver.get(pages.javascriptPage);
434432

@@ -489,9 +487,6 @@ public void testChordControlHomeShiftEndDelete() {
489487
assertThat(element.getAttribute("value")).isEqualTo("");
490488
}
491489

492-
// control-x control-v here for cut & paste tests, these work on windows
493-
// and linux, but not on the MAC.
494-
495490
@Test
496491
@NotYetImplemented(value = FIREFOX, reason = "https://github.com/mozilla/geckodriver/issues/646")
497492
public void testChordReveseShiftHomeSelectionDeletes() {
@@ -520,8 +515,9 @@ public void testChordReveseShiftHomeSelectionDeletes() {
520515
assertThat(element.getAttribute("value")).isEqualTo("");
521516
}
522517

518+
// control-x control-v here for cut & paste tests, these work on windows
519+
// and linux, but not on the MAC.
523520
@Test
524-
@Ignore(value = CHROME, reason = "https://bugs.chromium.org/p/chromedriver/issues/detail?id=3999")
525521
@NotYetImplemented(value = FIREFOX, reason = "https://github.com/mozilla/geckodriver/issues/646")
526522
public void testChordControlCutAndPaste() {
527523
assumeFalse("FIXME: macs don't have HOME keys, would PGUP work?",

0 commit comments

Comments
 (0)