[rb] add support to Firefox Options for environment capability

titusfortner · titusfortner · commit d7ae19b04be2 · 2021-11-23T17:10:08.000-06:00
diff --git a/rb/CHANGES b/rb/CHANGES
@@ -1,4 +1,4 @@
-4.1.0 (2021-11-18)
+4.1.0 (2021-11-22)
 =========================
 
 DevTools:
diff --git a/rb/lib/selenium/webdriver/firefox/options.rb b/rb/lib/selenium/webdriver/firefox/options.rb
@@ -25,11 +25,12 @@ class Options < WebDriver::Options
 
         KEY = 'moz:firefoxOptions'
 
-        # see: https://firefox-source-docs.mozilla.org/testing/geckodriver/Capabilities.html
+        # see: https://developer.mozilla.org/en-US/docs/Web/WebDriver/Capabilities/firefoxOptions
         CAPABILITIES = {binary: 'binary',
                         args: 'args',
                         log: 'log',
                         prefs: 'prefs',
+                        env: 'env',
                         android_package: 'androidPackage',
                         android_activity: 'androidActivity',
                         android_device_serial: 'androidDeviceSerial',
@@ -62,6 +63,7 @@ def initialize(log_level: nil, **opts)
 
           @options[:args] ||= []
           @options[:prefs] ||= {}
+          @options[:env] ||= {}
           @options[:log] ||= {level: log_level} if log_level
 
           process_profile(@options.delete(:profile))
diff --git a/rb/spec/unit/selenium/webdriver/firefox/options_spec.rb b/rb/spec/unit/selenium/webdriver/firefox/options_spec.rb
@@ -43,6 +43,7 @@ module Firefox
                                args: %w[foo bar],
                                binary: '/foo/bar',
                                prefs: {foo: 'bar'},
+                               env: {'FOO' => 'bar'},
                                foo: 'bar',
                                profile: profile,
                                log_level: :debug,
@@ -55,6 +56,7 @@ module Firefox
             expect(opts.args.to_a).to eq(%w[foo bar])
             expect(opts.binary).to eq('/foo/bar')
             expect(opts.prefs[:foo]).to eq('bar')
+            expect(opts.env['FOO']).to eq('bar')
             expect(opts.instance_variable_get('@options')[:foo]).to eq('bar')
             expect(opts.profile).to eq(profile)
             expect(opts.log_level).to eq(:debug)
@@ -90,6 +92,11 @@ module Firefox
             options.prefs[:foo] = 'bar'
             expect(options.prefs[:foo]).to eq('bar')
           end
+
+          it 'adds an ENV' do
+            options.env['FOO'] = 'bar'
+            expect(options.env['FOO']).to eq('bar')
+          end
         end
 
         describe '#log_level=' do
@@ -211,6 +218,7 @@ module Firefox
                                args: %w[foo bar],
                                binary: '/foo/bar',
                                prefs: {foo: 'bar'},
+                               env: {'FOO' => 'bar'},
                                foo: 'bar',
                                profile: profile,
                                log_level: :debug,
@@ -236,6 +244,7 @@ module Firefox
                                        key => {'args' => %w[foo bar],
                                                'binary' => '/foo/bar',
                                                'prefs' => {'foo' => 'bar'},
+                                               'env' => {'FOO' => 'bar'},
                                                'profile' => 'encoded_profile',
                                                'log' => {'level' => 'debug'},
                                                'foo' => 'bar',

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-4.1.0 (2021-11-18)`
	`1`	`+4.1.0 (2021-11-22)`
`2`	`2`	`=========================`
`3`	`3`
`4`	`4`	`DevTools:`