[grid] Changing method name to show real intention and usage

diemol · diemol · commit d61295a0b5c8 · 2022-01-19T14:51:11.000-05:00
diff --git a/java/src/org/openqa/selenium/grid/distributor/local/LocalDistributor.java b/java/src/org/openqa/selenium/grid/distributor/local/LocalDistributor.java
@@ -424,7 +424,7 @@ public Either<SessionNotCreatedException, CreateSessionResponse> newSession(Sess
       boolean retry = false;
       SessionNotCreatedException lastFailure = new SessionNotCreatedException("Unable to create new session");
       for (Capabilities caps : request.getDesiredCapabilities()) {
-        if (!isSupported(caps)) {
+        if (isNotSupported(caps)) {
           continue;
         }
 
@@ -561,8 +561,8 @@ private SlotId reserveSlot(RequestId requestId, Capabilities caps) {
     }
   }
 
-  private boolean isSupported(Capabilities caps) {
-    return getAvailableNodes().stream().anyMatch(node -> node.hasCapability(caps));
+  private boolean isNotSupported(Capabilities caps) {
+    return getAvailableNodes().stream().noneMatch(node -> node.hasCapability(caps));
   }
 
   private boolean reserve(SlotId id) {
@@ -630,7 +630,7 @@ public void run() {
     private void checkMatchingSlot(List<SessionRequestCapability> sessionRequests) {
       for(SessionRequestCapability request : sessionRequests) {
         long unmatchableCount = request.getDesiredCapabilities().stream()
-          .filter(caps -> !isSupported(caps))
+          .filter(LocalDistributor.this::isNotSupported)
           .count();
 
         if (unmatchableCount == request.getDesiredCapabilities().size()) {

Original file line number	Diff line number	Diff line change
`@@ -424,7 +424,7 @@ public Either<SessionNotCreatedException, CreateSessionResponse> newSession(Sess`
`424`	`424`	`boolean retry = false;`
`425`	`425`	`SessionNotCreatedException lastFailure = new SessionNotCreatedException("Unable to create new session");`
`426`	`426`	`for (Capabilities caps : request.getDesiredCapabilities()) {`
`427`		`- if (!isSupported(caps)) {`
	`427`	`+ if (isNotSupported(caps)) {`
`428`	`428`	`continue;`
`429`	`429`	`}`
`430`	`430`
`@@ -561,8 +561,8 @@ private SlotId reserveSlot(RequestId requestId, Capabilities caps) {`
`561`	`561`	`}`
`562`	`562`	`}`
`563`	`563`
`564`		`- private boolean isSupported(Capabilities caps) {`
`565`		`- return getAvailableNodes().stream().anyMatch(node -> node.hasCapability(caps));`
	`564`	`+ private boolean isNotSupported(Capabilities caps) {`
	`565`	`+ return getAvailableNodes().stream().noneMatch(node -> node.hasCapability(caps));`
`566`	`566`	`}`
`567`	`567`
`568`	`568`	`private boolean reserve(SlotId id) {`
`@@ -630,7 +630,7 @@ public void run() {`
`630`	`630`	`private void checkMatchingSlot(List<SessionRequestCapability> sessionRequests) {`
`631`	`631`	`for(SessionRequestCapability request : sessionRequests) {`
`632`	`632`	`long unmatchableCount = request.getDesiredCapabilities().stream()`
`633`		`- .filter(caps -> !isSupported(caps))`
	`633`	`+ .filter(LocalDistributor.this::isNotSupported)`
`634`	`634`	`.count();`
`635`	`635`
`636`	`636`	`if (unmatchableCount == request.getDesiredCapabilities().size()) {`