[rb] fix test with bad syntax

titusfortner · titusfortner · commit d3ed02ad4fd0 · 2022-05-07T18:59:25.000-05:00
diff --git a/rb/spec/integration/selenium/webdriver/firefox/driver_spec.rb b/rb/spec/integration/selenium/webdriver/firefox/driver_spec.rb
@@ -52,11 +52,11 @@ module Firefox
             screenshot = driver.save_full_page_screenshot(path)
 
             if Platform.linux?
-              expect(File.read(screenshot)[0x10..0x18].unpack('NN')).first.to be >= viewport_width
-              expect(File.read(screenshot)[0x10..0x18].unpack('NN')).last.to be > viewport_height
+              expect(File.read(screenshot)[0x10..0x18].unpack1('NN')).to be >= viewport_width
+              expect(File.read(screenshot)[0x10..0x18].unpack('NN').last).to be > viewport_height
             else
-              expect((File.read(screenshot)[0x10..0x18].unpack('NN')).first/2).to be >= viewport_width
-              expect((File.read(screenshot)[0x10..0x18].unpack('NN')).last/2).to be > viewport_height
+              expect(File.read(screenshot)[0x10..0x18].unpack1('NN') / 2).to be >= viewport_width
+              expect(File.read(screenshot)[0x10..0x18].unpack('NN').last / 2).to be > viewport_height
             end
 
           ensure
diff --git a/rb/spec/integration/selenium/webdriver/takes_screenshot_spec.rb b/rb/spec/integration/selenium/webdriver/takes_screenshot_spec.rb
@@ -87,11 +87,11 @@ def save_screenshot_and_assert(source, path)
           screenshot = driver.save_screenshot path
 
           if Platform.linux?
-            expect(File.read(screenshot)[0x10..0x18].unpack('NN')).first.to be <= viewport_width
-            expect(File.read(screenshot)[0x10..0x18].unpack('NN')).last.to be <= viewport_height
+            expect(File.read(screenshot)[0x10..0x18].unpack1('NN')).to be <= viewport_width
+            expect(File.read(screenshot)[0x10..0x18].unpack('NN').last).to be <= viewport_height
           else
-            expect((File.read(screenshot)[0x10..0x18].unpack('NN')).first/2).to be <= viewport_width
-            expect((File.read(screenshot)[0x10..0x18].unpack('NN')).last/2).to be <= viewport_height
+            expect(File.read(screenshot)[0x10..0x18].unpack1('NN') / 2).to be <= viewport_width
+            expect(File.read(screenshot)[0x10..0x18].unpack('NN').last / 2).to be <= viewport_height
           end
         end
 
@@ -101,11 +101,11 @@ def save_screenshot_and_assert(source, path)
 
           screenshot = driver.save_screenshot path, full_page: true
           if Platform.linux?
-            expect(File.read(screenshot)[0x10..0x18].unpack('NN')).first.to be >= viewport_width
-            expect(File.read(screenshot)[0x10..0x18].unpack('NN')).last.to be > viewport_height
+            expect(File.read(screenshot)[0x10..0x18].unpack1('NN')).to be >= viewport_width
+            expect(File.read(screenshot)[0x10..0x18].unpack('NN').last).to be > viewport_height
           else
-            expect((File.read(screenshot)[0x10..0x18].unpack('NN')).first/2).to be >= viewport_width
-            expect((File.read(screenshot)[0x10..0x18].unpack('NN')).last/2).to be > viewport_height
+            expect(File.read(screenshot)[0x10..0x18].unpack1('NN') / 2).to be >= viewport_width
+            expect(File.read(screenshot)[0x10..0x18].unpack('NN').last / 2).to be > viewport_height
           end
         end
 
