feat(java): add webdriver.edge.loglevel (#10962)

hgsgtk · diemol · web-flow · commit ce2ee20de51c · 2022-08-22T13:09:46.000+02:00
It adds a new system property `webdriver.edge.loglevel` on EdgeDriverService. It allows us to configure the log level in detail. For example, if you use version 104.0.1293.63 Microsoft Edge WebDriver, you can choose one from ALL, DEBUG, INFO, WARNING, SEVERE, or OFF. ``` $ ./msedgedriver --help --log-level=LEVEL set log level: ALL, DEBUG, INFO, WARNING, SEVERE, OFF ``` What this system property does is to make sure to specify the `--log-level` option like the others. Fixes #10961 Co-authored-by: Diego Molina <diemol@users.noreply.github.com>
diff --git a/java/src/org/openqa/selenium/edge/EdgeDriverService.java b/java/src/org/openqa/selenium/edge/EdgeDriverService.java
@@ -50,6 +50,11 @@ public class EdgeDriverService extends DriverService {
    */
   public static final String EDGE_DRIVER_LOG_PROPERTY = "webdriver.edge.logfile";
 
+  /**
+   * System property that defines the log level when MicrosoftWebDriver output is logged.
+   */
+  public static final String EDGE_DRIVER_LOG_LEVEL_PROPERTY = "webdriver.edge.loglevel";
+
   /**
    * Boolean system property that defines whether the MicrosoftWebDriver executable should be started
    * with verbose logging.
@@ -114,6 +119,7 @@ public static class Builder extends DriverService.Builder<
 
     private final boolean disableBuildCheck = Boolean.getBoolean(EDGE_DRIVER_DISABLE_BUILD_CHECK);
     private boolean verbose = Boolean.getBoolean(EDGE_DRIVER_VERBOSE_LOG_PROPERTY);
+    private String loglevel = System.getProperty(EDGE_DRIVER_LOG_LEVEL_PROPERTY);
     private boolean silent = Boolean.getBoolean(EDGE_DRIVER_SILENT_OUTPUT_PROPERTY);
     private String allowedListIps = System.getProperty(EDGE_DRIVER_ALLOWED_IPS_PROPERTY);
 
@@ -148,6 +154,14 @@ public EdgeDriverService.Builder withVerbose(boolean verbose) {
       return this;
     }
 
+    /**
+     * Configures the driver server log level.
+     */
+    public EdgeDriverService.Builder withLoglevel(String level) {
+      this.loglevel = level;
+      return this;
+    }
+
     /**
      * Configures the driver server for silent output.
      *
@@ -199,6 +213,9 @@ protected List<String> createArgs() {
       if (silent) {
         args.add("--silent");
       }
+      if (loglevel != null) {
+        args.add(String.format("--log-level=%s", loglevel));
+      }
       if (allowedListIps != null) {
         args.add(String.format("--whitelisted-ips=%s", allowedListIps));
       }
