[js] do not convert tag name to css selector

titusfortner · titusfortner · commit ca39d6f8f0ff · 2022-04-14T16:20:48.000-05:00
diff --git a/javascript/node/selenium-webdriver/lib/by.js b/javascript/node/selenium-webdriver/lib/by.js
@@ -225,7 +225,7 @@ class By {
    * @return {!By} The new locator.
    */
   static tagName(name) {
-    return By.css(name)
+    return new By('tag name', name)
   }
 
   /**
diff --git a/javascript/node/selenium-webdriver/test/lib/by_test.js b/javascript/node/selenium-webdriver/test/lib/by_test.js
@@ -93,7 +93,7 @@ describe('by', function () {
 
       let expected = {
         relative: {
-          root: { 'css selector': 'p' },
+          root: { 'tag name': 'p' },
           filters: [
             { kind: 'above', args: [{ 'css selector': '*[name="foobar"]' }] },
           ],
@@ -163,7 +163,7 @@ describe('by', function () {
 
     it('accepts tagName', function () {
       let locator = by.checkedLocator({ tagName: 'div' })
-      assert.strictEqual('css selector', locator.using)
+      assert.strictEqual('tag name', locator.using)
       assert.strictEqual('div', locator.value)
     })
 
diff --git a/javascript/node/selenium-webdriver/test/lib/webdriver_test.js b/javascript/node/selenium-webdriver/test/lib/webdriver_test.js
@@ -762,7 +762,7 @@ describe('WebDriver', function () {
 
     it('customLocator', function () {
       let executor = new FakeExecutor()
-        .expect(CName.FIND_ELEMENTS, { using: 'css selector', value: 'a' })
+        .expect(CName.FIND_ELEMENTS, { using: 'css selector', value: '.a' })
         .andReturnSuccess([
           WebElement.buildId('foo'),
           WebElement.buildId('bar'),
@@ -774,7 +774,7 @@ describe('WebDriver', function () {
       const driver = executor.createDriver()
       const element = driver.findElement(function (d) {
         assert.strictEqual(driver, d)
-        return d.findElements(By.tagName('a'))
+        return d.findElements(By.className('a'))
       })
       return element.click()
     })
@@ -797,13 +797,13 @@ describe('WebDriver', function () {
     it('returnsMultipleElements', function () {
       const ids = ['foo', 'bar', 'baz']
       let executor = new FakeExecutor()
-        .expect(CName.FIND_ELEMENTS, { using: 'css selector', value: 'a' })
+        .expect(CName.FIND_ELEMENTS, { using: 'css selector', value: '.a' })
         .andReturnSuccess(ids.map(WebElement.buildId))
         .end()
 
       const driver = executor.createDriver()
       return driver
-        .findElements(By.tagName('a'))
+        .findElements(By.className('a'))
         .then(function (elements) {
           return Promise.all(
             elements.map(function (e) {

Original file line number	Diff line number	Diff line change
`@@ -225,7 +225,7 @@ class By {`
`225`	`225`	`* @return {!By} The new locator.`
`226`	`226`	`*/`
`227`	`227`	`static tagName(name) {`
`228`		`- return By.css(name)`
	`228`	`+ return new By('tag name', name)`
`229`	`229`	`}`
`230`	`230`
`231`	`231`	`/**`