[dotnet] according to the rfc section 5.3 a cookie name is allowed to be an empty string so long as the value is not also an empty string

titusfortner · titusfortner · commit c8fdee5e188e · 2021-12-26T15:35:51.000-06:00
diff --git a/dotnet/src/webdriver/Cookie.cs b/dotnet/src/webdriver/Cookie.cs
@@ -115,22 +115,27 @@ public Cookie(string name, string value, string domain, string path, DateTime? e
         /// <param name="isSecure"><see langword="true"/> if the cookie is secure; otherwise <see langword="false"/></param>
         /// <param name="isHttpOnly"><see langword="true"/> if the cookie is an HTTP-only cookie; otherwise <see langword="false"/></param>
         /// <param name="sameSite">The SameSite value of cookie.</param>
-        /// <exception cref="ArgumentException">If the name is <see langword="null"/> or an empty string,
-        /// or if it contains a semi-colon.</exception>
-        /// <exception cref="ArgumentNullException">If the value or currentUrl is <see langword="null"/>.</exception>
+        /// <exception cref="ArgumentException">If the name and value are both an empty string,
+        /// or if the name contains a semi-colon.</exception>
+        /// <exception cref="ArgumentNullException">If the name, value or currentUrl is <see langword="null"/>.</exception>
         /// <exception cref="ArgumentNullException">If the same site value is not valid or same site value is "None" but secure is set to false.</exception>
         public Cookie(string name, string value, string domain, string path, DateTime? expiry, bool secure, bool isHttpOnly, string sameSite)
         {
-            if (string.IsNullOrEmpty(name))
+            if (name == null)
             {
-                throw new ArgumentException("Cookie name cannot be null or empty string", nameof(name));
+                throw new ArgumentNullException(nameof(value), "Cookie name cannot be null");
             }
 
             if (value == null)
             {
                 throw new ArgumentNullException(nameof(value), "Cookie value cannot be null");
             }
 
+            if (name == string.Empty && value == string.Empty)
+            {
+                throw new ArgumentException("Cookie name and value cannot both be empty string");
+            }
+
             if (name.IndexOf(';') != -1)
             {
                 throw new ArgumentException("Cookie names cannot contain a ';': " + name, nameof(name));
diff --git a/dotnet/test/common/CookieTest.cs b/dotnet/test/common/CookieTest.cs
@@ -19,6 +19,12 @@ public void ShouldThrowAnExceptionWhenSemiColonExistsInTheCookieAttribute()
             Assert.That(() => new ReturnedCookie("hi;hi", "value", null, null, DateTime.Now, false, false), Throws.InstanceOf<ArgumentException>());
         }
 
+        [Test]
+        public void ShouldThrowAnExceptionWhenNameAndValueAreEmpty()
+        {
+            Assert.That(() => new ReturnedCookie("", "", null, null, DateTime.Now, false, false), Throws.InstanceOf<ArgumentException>());
+        }
+
         [Test]
         public void ShouldThrowAnExceptionWhenTheNameIsNull()
         {

Original file line number	Diff line number	Diff line change
`@@ -115,22 +115,27 @@ public Cookie(string name, string value, string domain, string path, DateTime? e`
`115`	`115`	`/// <param name="isSecure"><see langword="true"/> if the cookie is secure; otherwise <see langword="false"/></param>`
`116`	`116`	`/// <param name="isHttpOnly"><see langword="true"/> if the cookie is an HTTP-only cookie; otherwise <see langword="false"/></param>`
`117`	`117`	`/// <param name="sameSite">The SameSite value of cookie.</param>`
`118`		`- /// <exception cref="ArgumentException">If the name is <see langword="null"/> or an empty string,`
`119`		`- /// or if it contains a semi-colon.</exception>`
`120`		`- /// <exception cref="ArgumentNullException">If the value or currentUrl is <see langword="null"/>.</exception>`
	`118`	`+ /// <exception cref="ArgumentException">If the name and value are both an empty string,`
	`119`	`+ /// or if the name contains a semi-colon.</exception>`
	`120`	`+ /// <exception cref="ArgumentNullException">If the name, value or currentUrl is <see langword="null"/>.</exception>`
`121`	`121`	`/// <exception cref="ArgumentNullException">If the same site value is not valid or same site value is "None" but secure is set to false.</exception>`
`122`	`122`	`public Cookie(string name, string value, string domain, string path, DateTime? expiry, bool secure, bool isHttpOnly, string sameSite)`
`123`	`123`	`{`
`124`		`- if (string.IsNullOrEmpty(name))`
	`124`	`+ if (name == null)`
`125`	`125`	`{`
`126`		`- throw new ArgumentException("Cookie name cannot be null or empty string", nameof(name));`
	`126`	`+ throw new ArgumentNullException(nameof(value), "Cookie name cannot be null");`
`127`	`127`	`}`
`128`	`128`
`129`	`129`	`if (value == null)`
`130`	`130`	`{`
`131`	`131`	`throw new ArgumentNullException(nameof(value), "Cookie value cannot be null");`
`132`	`132`	`}`
`133`	`133`
	`134`	`+ if (name == string.Empty && value == string.Empty)`
	`135`	`+ {`
	`136`	`+ throw new ArgumentException("Cookie name and value cannot both be empty string");`
	`137`	`+ }`
	`138`	`+`
`134`	`139`	`if (name.IndexOf(';') != -1)`
`135`	`140`	`{`
`136`	`141`	`throw new ArgumentException("Cookie names cannot contain a ';': " + name, nameof(name));`
Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,12 @@ public void ShouldThrowAnExceptionWhenSemiColonExistsInTheCookieAttribute()`
`19`	`19`	`Assert.That(() => new ReturnedCookie("hi;hi", "value", null, null, DateTime.Now, false, false), Throws.InstanceOf<ArgumentException>());`
`20`	`20`	`}`
`21`	`21`
	`22`	`+ [Test]`
	`23`	`+ public void ShouldThrowAnExceptionWhenNameAndValueAreEmpty()`
	`24`	`+ {`
	`25`	`+ Assert.That(() => new ReturnedCookie("", "", null, null, DateTime.Now, false, false), Throws.InstanceOf<ArgumentException>());`
	`26`	`+ }`
	`27`	`+`
`22`	`28`	`[Test]`
`23`	`29`	`public void ShouldThrowAnExceptionWhenTheNameIsNull()`
`24`	`30`	`{`