Skip to content

Commit c063709

Browse files
authored
fix some typos in code and documentation (#11009)
1 parent 7f54c8f commit c063709

17 files changed

Lines changed: 36 additions & 36 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ bazel test //java/... --test_size_filters=small,medium,large --test_tag_filters=
122122
```
123123

124124
The `test_size_filters` argument takes small, medium, large. Small are akin to unit tests,
125-
medium is akin to integration tests, and large is akin to end to end tests.
125+
medium is akin to integration tests, and large is akin to end-to-end tests.
126126

127127
The `test_tag_filters` allow us to pass in browser names and a few different tags that we can
128128
find in the code base.

common/devtools/browser_protocol.json

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6461,11 +6461,11 @@
64616461
},
64626462
{
64636463
"name": "clearDeviceMetricsOverride",
6464-
"description": "Clears the overriden device metrics."
6464+
"description": "Clears the overridden device metrics."
64656465
},
64666466
{
64676467
"name": "clearGeolocationOverride",
6468-
"description": "Clears the overriden Geolocation Position and Error."
6468+
"description": "Clears the overridden Geolocation Position and Error."
64696469
},
64706470
{
64716471
"name": "resetPageScaleFactor",
@@ -6779,7 +6779,7 @@
67796779
},
67806780
{
67816781
"name": "initialVirtualTime",
6782-
"description": "If set, base::Time::Now will be overriden to initially return this value.",
6782+
"description": "If set, base::Time::Now will be overridden to initially return this value.",
67836783
"optional": true,
67846784
"$ref": "Network.TimeSinceEpoch"
67856785
}
@@ -12383,7 +12383,7 @@
1238312383
},
1238412384
{
1238512385
"name": "clearDeviceMetricsOverride",
12386-
"description": "Clears the overriden device metrics.",
12386+
"description": "Clears the overridden device metrics.",
1238712387
"experimental": true,
1238812388
"deprecated": true,
1238912389
"redirect": "Emulation"
@@ -12397,7 +12397,7 @@
1239712397
},
1239812398
{
1239912399
"name": "clearGeolocationOverride",
12400-
"description": "Clears the overriden Geolocation Position and Error.",
12400+
"description": "Clears the overridden Geolocation Position and Error.",
1240112401
"deprecated": true,
1240212402
"redirect": "Emulation"
1240312403
},
@@ -17189,4 +17189,4 @@
1718917189
]
1719017190
}
1719117191
]
17192-
}
17192+
}

common/devtools/chromium/v85/browser_protocol.pdl

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2969,10 +2969,10 @@ domain Emulation
29692969
# True if emulation is supported.
29702970
boolean result
29712971

2972-
# Clears the overriden device metrics.
2972+
# Clears the overridden device metrics.
29732973
command clearDeviceMetricsOverride
29742974

2975-
# Clears the overriden Geolocation Position and Error.
2975+
# Clears the overridden Geolocation Position and Error.
29762976
command clearGeolocationOverride
29772977

29782978
# Requests that page scale factor is reset to initial values.
@@ -3120,7 +3120,7 @@ domain Emulation
31203120
# If set the virtual time policy change should be deferred until any frame starts navigating.
31213121
# Note any previous deferred policy change is superseded.
31223122
optional boolean waitForNavigation
3123-
# If set, base::Time::Now will be overriden to initially return this value.
3123+
# If set, base::Time::Now will be overridden to initially return this value.
31243124
optional Network.TimeSinceEpoch initialVirtualTime
31253125
returns
31263126
# Absolute timestamp at which virtual time was first enabled (up time in milliseconds).
@@ -5776,7 +5776,7 @@ domain Page
57765776
# Serialized page data.
57775777
string data
57785778

5779-
# Clears the overriden device metrics.
5779+
# Clears the overridden device metrics.
57805780
experimental deprecated command clearDeviceMetricsOverride
57815781
# Use 'Emulation.clearDeviceMetricsOverride' instead
57825782
redirect Emulation
@@ -5786,7 +5786,7 @@ domain Page
57865786
# Use 'DeviceOrientation.clearDeviceOrientationOverride' instead
57875787
redirect DeviceOrientation
57885788

5789-
# Clears the overriden Geolocation Position and Error.
5789+
# Clears the overridden Geolocation Position and Error.
57905790
deprecated command clearGeolocationOverride
57915791
# Use 'Emulation.clearGeolocationOverride' instead
57925792
redirect Emulation

common/src/web/rc/tests/TestGet.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
</td>
2929
</tr>
3030
<!-- test API getters -->
31-
31+
3232
<tr>
3333
<td>open</td>
3434
<td>../tests/html/test_get.html</td>
@@ -37,13 +37,13 @@
3737

3838
<!-- IE uppercases the property names of the style.
3939
Firefox lowercases the property names of the style.
40-
IE omits the trailing semi-colon. -->
40+
IE omits the trailing semicolon. -->
4141
<tr>
4242
<td>verifyAttribute</td>
4343
<td>//img[@alt='banner']@style</td>
4444
<td>regexp:(width|WIDTH): 644px; (height|HEIGHT): 41px(;?)</td>
4545
</tr>
46-
46+
4747
<!-- This asserts on the current behavior of selArrayToString(). Commas and
4848
backslashes are escaped in array values. Backslash-craziness!! -->
4949
<tr>

java/src/org/openqa/selenium/WebElement.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ default String getDomAttribute(String name) {
140140
* neither exists, null is returned.
141141
* <p>
142142
* The "style" attribute is converted as best can be to a text representation with a trailing
143-
* semi-colon.
143+
* semicolon.
144144
* <p>
145145
* The following are deemed to be "boolean" attributes, and will return either "true" or null:
146146
* <p>

java/src/org/openqa/selenium/grid/data/SessionRequest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ public SessionRequest(
8484
Map<String, Object> metadata,
8585
Map<String, String> traceHeaders) {
8686
this.requestId = Require.nonNull("Request ID", requestId);
87-
this.enqueued = Require.nonNull("Enqueud time", enqueued);
87+
this.enqueued = Require.nonNull("Enqueued time", enqueued);
8888
this.downstreamDialects = unmodifiableSet(
8989
new HashSet<>(Require.nonNull("Downstream dialects", downstreamDialects)));
9090
this.desiredCapabilities = unmodifiableSet(

java/src/org/openqa/selenium/grid/sessionmap/jdbc/JdbcBackedSessionMap.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ public static SessionMap create(Config config) {
117117
public boolean isReady() {
118118
try {
119119
return !connection.isClosed();
120-
} catch (SQLException throwables) {
120+
} catch (SQLException throwable) {
121121
return false;
122122
}
123123
}

java/src/org/openqa/selenium/remote/http/jdk/JdkHttpClient.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ public WebSocket send(Message message) {
168168
CloseMessage closeMessage = (CloseMessage) message;
169169
makeCall = () -> underlyingSocket.sendClose(closeMessage.code(), closeMessage.reason());
170170
} else {
171-
throw new IllegalArgumentException("Unsupport message type: " + message);
171+
throw new IllegalArgumentException("Unsupported message type: " + message);
172172
}
173173

174174
synchronized (underlyingSocket) {

java/src/org/openqa/selenium/support/ui/ExpectedConditions.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1230,7 +1230,7 @@ public String toString() {
12301230
*
12311231
* @param element used as parent element. For example table with locator By.xpath("//table")
12321232
* @param childLocator used to find child element. For example td By.xpath("./tr/td")
1233-
* @return visible subelement
1233+
* @return visible sub-element
12341234
*/
12351235
public static ExpectedCondition<List<WebElement>> visibilityOfNestedElementsLocatedBy(
12361236
final WebElement element, final By childLocator) {
@@ -1261,7 +1261,7 @@ public String toString() {
12611261
* @param locator used to check parent element. For example table with locator
12621262
* By.xpath("//table")
12631263
* @param childLocator used to find child element. For example td By.xpath("./tr/td")
1264-
* @return subelement
1264+
* @return sub-element
12651265
*/
12661266
public static ExpectedCondition<WebElement> presenceOfNestedElementLocatedBy(
12671267
final By locator, final By childLocator)
@@ -1285,7 +1285,7 @@ public String toString() {
12851285
*
12861286
* @param element used as parent element
12871287
* @param childLocator used to find child element. For example td By.xpath("./tr/td")
1288-
* @return subelement
1288+
* @return sub-element
12891289
*/
12901290
public static ExpectedCondition<WebElement> presenceOfNestedElementLocatedBy(
12911291
final WebElement element, final By childLocator)
@@ -1311,7 +1311,7 @@ public String toString() {
13111311
* @param parent used to check parent element. For example table with locator
13121312
* By.xpath("//table")
13131313
* @param childLocator used to find child element. For example td By.xpath("./tr/td")
1314-
* @return subelement
1314+
* @return sub-element
13151315
*/
13161316
public static ExpectedCondition<List<WebElement>> presenceOfNestedElementsLocatedBy(
13171317
final By parent, final By childLocator)

java/test/com/thoughtworks/selenium/corebased/TestGet.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ public void testGet() {
3131
selenium.open("test_get.html");
3232
// IE uppercases the property names of the style.
3333
// Firefox lowercases the property names of the style.
34-
// IE omits the trailing semi-colon.
34+
// IE omits the trailing semicolon.
3535
verifyTrue(Pattern.compile("(width|WIDTH): 644px; (height|HEIGHT): 41px(;?)")
3636
.matcher(selenium.getAttribute("//img[@alt='banner']@style")).find());
3737
// This asserts on the current behavior of selArrayToString(). Commas and

0 commit comments

Comments
 (0)