fix: geckodriver session with node 18.x.x (issue 2 in #10970)

harsha509 · harsha509 · commit b9402997580a · 2022-08-26T17:48:15.000+05:30
diff --git a/javascript/node/selenium-webdriver/io/exec.js b/javascript/node/selenium-webdriver/io/exec.js
@@ -162,5 +162,5 @@ module.exports = {
   Command,
   Options,
   Result,
-  exec
+  exec,
 }
diff --git a/javascript/node/selenium-webdriver/lib/test/httpserver.js b/javascript/node/selenium-webdriver/lib/test/httpserver.js
@@ -56,11 +56,11 @@ let Server = function (requestHandler) {
       typeof opt_port !== 'function',
       'start invoked with function, not port (mocha callback)?'
     )
-    const port = opt_port || portprober.findFreePort('localhost')
+    const port = opt_port || portprober.findFreePort('127.0.0.1')
     return Promise.resolve(port)
       .then((port) => {
         return promise.checkedNodeCall(
-          server.listen.bind(server, port, 'localhost')
+          server.listen.bind(server, port, '127.0.0.1')
         )
       })
       .then(function () {
diff --git a/javascript/node/selenium-webdriver/net/index.js b/javascript/node/selenium-webdriver/net/index.js
@@ -76,11 +76,7 @@ function getAddress(family = 'IPv4') {
  * @return {(string|undefined)} The IP address or undefined if not available.
  */
 function getLoopbackAddress(family = 'IPv4') {
-  let address = getIPAddress(true, family)
-  if (address === '127.0.0.1') {
-    address = 'localhost'
-  }
-  return address
+  return getIPAddress(true, family)
 }
 
 /**
diff --git a/javascript/node/selenium-webdriver/test/virtualAuthenticator_test.js b/javascript/node/selenium-webdriver/test/virtualAuthenticator_test.js
@@ -136,7 +136,9 @@ suite(function (env) {
 
   beforeEach(async function () {
     driver = await env.builder().build()
-    await driver.get(fileServer.Pages.virtualAuthenticator)
+    await driver.get(
+      fileServer.Pages.virtualAuthenticator.replace('127.0.0.1', 'localhost')
+    )
     assert.strictEqual(await driver.getTitle(), 'Virtual Authenticator Tests')
   })
 
diff --git a/javascript/node/selenium-webdriver/test/window_test.js b/javascript/node/selenium-webdriver/test/window_test.js
@@ -52,7 +52,9 @@ test.suite(function (env) {
   it('can set size of the current window from iframe', async function () {
     await driver.get(test.Pages.iframePage)
 
-    const frame = await driver.findElement({ css: 'iframe[name="iframe1-name"]' })
+    const frame = await driver.findElement({
+      css: 'iframe[name="iframe1-name"]',
+    })
     await driver.switchTo().frame(frame)
     await changeSizeBy(-20, -20)
   })

Original file line number	Diff line number	Diff line change
`@@ -162,5 +162,5 @@ module.exports = {`
`162`	`162`	`Command,`
`163`	`163`	`Options,`
`164`	`164`	`Result,`
`165`		`- exec`
	`165`	`+ exec,`
`166`	`166`	`}`
Original file line number	Diff line number	Diff line change
`@@ -56,11 +56,11 @@ let Server = function (requestHandler) {`
`56`	`56`	`typeof opt_port !== 'function',`
`57`	`57`	`'start invoked with function, not port (mocha callback)?'`
`58`	`58`	`)`
`59`		`- const port = opt_port \|\| portprober.findFreePort('localhost')`
	`59`	`+ const port = opt_port \|\| portprober.findFreePort('127.0.0.1')`
`60`	`60`	`return Promise.resolve(port)`
`61`	`61`	`.then((port) => {`
`62`	`62`	`return promise.checkedNodeCall(`
`63`		`- server.listen.bind(server, port, 'localhost')`
	`63`	`+ server.listen.bind(server, port, '127.0.0.1')`
`64`	`64`	`)`
`65`	`65`	`})`
`66`	`66`	`.then(function () {`