issue-1533899181 (#11551)

RussiaVk · web-flow · commit b8b2f61e3c50 · 2023-02-27T17:30:54.000+01:00
* issue-1533899181 solve array ClassCastException * replace var (jeps-286) with int * Update WebElementToJsonConverterTest.java Add test code for specific type of array * Update WebElementToJsonConverter.java --------- Co-authored-by: Diego Molina <diemol@users.noreply.github.com> Fixes #11550
diff --git a/java/src/org/openqa/selenium/remote/internal/WebElementToJsonConverter.java b/java/src/org/openqa/selenium/remote/internal/WebElementToJsonConverter.java
@@ -21,13 +21,14 @@
 import org.openqa.selenium.WrapsElement;
 import org.openqa.selenium.remote.Dialect;
 import org.openqa.selenium.remote.RemoteWebElement;
-
+import java.util.ArrayList;
+import java.util.List;
 import java.util.Arrays;
 import java.util.Collection;
 import java.util.HashMap;
 import java.util.Map;
 import java.util.function.Function;
-
+import java.lang.reflect.Array;
 import static java.util.stream.Collectors.toList;
 
 /**
@@ -58,7 +59,7 @@ public Object apply(Object arg) {
     }
 
     if (arg.getClass().isArray()) {
-      arg = Arrays.asList((Object[]) arg);
+      arg = arrayToList(arg);
     }
 
     if (arg instanceof Collection<?>) {
@@ -83,4 +84,12 @@ public Object apply(Object arg) {
     throw new IllegalArgumentException(
         "Argument is of an illegal type: " + arg.getClass().getName());
   }
+  
+  private static List<Object> arrayToList(Object array) {
+    List<Object> list = new ArrayList<>();
+    for (int i = 0; i < Array.getLength(array); i++) {
+        list.add(Array.get(array, i));
+    }
+    return list;
+  }
 }
diff --git a/java/test/org/openqa/selenium/remote/internal/WebElementToJsonConverterTest.java b/java/test/org/openqa/selenium/remote/internal/WebElementToJsonConverterTest.java
@@ -191,13 +191,18 @@ void convertsAMapWithAWebElement() {
 
   @Test
   void convertsAnArray() {
-    Object value = CONVERTER.apply(new Object[] {
+    Object value1 = CONVERTER.apply(new Object[] {
         "abc123", true, 123, Math.PI
     });
 
-    assertThat(value).isInstanceOf(Collection.class);
-    assertContentsInOrder(new ArrayList<>((Collection<?>) value),
+    assertThat(value1).isInstanceOf(Collection.class);
+    assertContentsInOrder(new ArrayList<>((Collection<?>) value1),
         "abc123", true, 123, Math.PI);
+    
+    Object value2 = CONVERTER.apply(new int[] { 123, 456, 789 });
+    
+		assertThat(value2).isInstanceOf(Collection.class);
+		assertContentsInOrder(new ArrayList<>((Collection<?>) value2), 123, 456, 789);
   }
 
   @Test
