[rb] setting log value does not apply to Safari

titusfortner · titusfortner · commit b571cd7e3583 · 2023-06-03T16:09:41.000-05:00
this is easier than implementing log separately in each of the other service classes
diff --git a/rb/lib/selenium/webdriver/safari/service.rb b/rb/lib/selenium/webdriver/safari/service.rb
@@ -24,6 +24,16 @@ class Service < WebDriver::Service
         DEFAULT_PORT = 7050
         EXECUTABLE = 'safaridriver'
         SHUTDOWN_SUPPORTED = false
+
+        def initialize(path: nil, port: nil, log: nil, args: nil)
+          raise Error::WebDriverError, 'Safari Service does not support setting log output' if log
+
+          super
+        end
+
+        def log=(*)
+          raise Error::WebDriverError, 'Safari Service does not support setting log output'
+        end
       end # Service
     end # Safari
   end # WebDriver
diff --git a/rb/spec/unit/selenium/webdriver/safari/service_spec.rb b/rb/spec/unit/selenium/webdriver/safari/service_spec.rb
@@ -30,6 +30,12 @@ module Safari
             allow(Platform).to receive(:assert_executable).and_return(true)
           end
 
+          it 'does not allow log' do
+            expect {
+              described_class.new(log: 'anywhere')
+            }.to raise_exception(Error::WebDriverError, 'Safari Service does not support setting log output')
+          end
+
           it 'uses default port and nil path' do
             service = described_class.new
 
@@ -57,6 +63,13 @@ module Safari
             expect(service.extra_args).to be_empty
           end
 
+          it 'does not allow log=' do
+            service = described_class.new
+            expect {
+              service.log = 'anywhere'
+            }.to raise_exception(Error::WebDriverError, 'Safari Service does not support setting log output')
+          end
+
           it 'uses provided args' do
             allow(Platform).to receive(:find_binary).and_return(service_path)
 
