Skip to content

Commit a97b1dd

Browse files
[py] Handle proxy being capitalised
1 parent 056f41e commit a97b1dd

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

py/selenium/webdriver/remote/remote_connection.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ def _get_connection_manager(self):
137137
pool_manager_init_args['ca_certs'] = self._ca_certs
138138

139139
if self._proxy_url:
140-
if self._proxy_url.startswith('sock'):
140+
if self._proxy_url.lower().startswith('sock'):
141141
from urllib3.contrib.socks import SOCKSProxyManager
142142
return SOCKSProxyManager(self._proxy_url, **pool_manager_init_args)
143143
return urllib3.ProxyManager(self._proxy_url, **pool_manager_init_args)

py/test/unit/selenium/webdriver/remote/remote_connection_tests.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,8 +149,8 @@ def mock_proxy_settings_missing(monkeypatch):
149149

150150
@pytest.fixture(scope="function")
151151
def mock_socks_proxy_settings(monkeypatch):
152-
http_proxy = 'socks5://http_proxy.com:8080'
153-
https_proxy = 'socks5://https_proxy.com:8080'
152+
http_proxy = 'SOCKS5://http_proxy.com:8080'
153+
https_proxy = 'SOCKS5://https_proxy.com:8080'
154154
monkeypatch.setenv("HTTPS_PROXY", https_proxy)
155155
monkeypatch.setenv("HTTP_PROXY", http_proxy)
156156
monkeypatch.setenv("https_proxy", https_proxy)

0 commit comments

Comments
 (0)