[rb] add more logging to Selenium Manager

titusfortner · titusfortner · commit a90d7fb605d7 · 2023-03-21T09:37:31.000-05:00
diff --git a/rb/.rubocop.yml b/rb/.rubocop.yml
@@ -16,7 +16,7 @@ Layout/SpaceInsideHashLiteralBraces:
   EnforcedStyle: no_space
 
 Metrics/AbcSize:
-  Max: 28
+  Max: 30
   Exclude:
     - 'lib/selenium/webdriver/remote/capabilities.rb'
     - 'lib/selenium/webdriver/remote/http/curb.rb'
@@ -35,8 +35,8 @@ Metrics/ClassLength:
     - 'lib/selenium/webdriver/common/driver.rb'
     - 'lib/selenium/webdriver/remote/bridge.rb'
     - 'lib/selenium/webdriver/remote/capabilities.rb'
-    - 'spec/integration/selenium/webdriver/bidi/log_inspector_spec.rb'
     - 'spec/integration/selenium/webdriver/spec_support/test_environment.rb'
+    - 'spec/**/*.rb'
 
 Metrics/CyclomaticComplexity:
   Max: 9
diff --git a/rb/lib/selenium/webdriver/common/selenium_manager.rb b/rb/lib/selenium/webdriver/common/selenium_manager.rb
@@ -33,6 +33,9 @@ class << self
         # @param [Options] options browser options.
         # @return [String] the path to the correct driver.
         def driver_path(options)
+          message = "driver for #{options.browser_name} not found; attempting to install with Selenium Manager"
+          WebDriver.logger.warn(message)
+
           unless options.is_a?(Options)
             raise ArgumentError, "SeleniumManager requires a WebDriver::Options instance, not a #{options.inspect}"
           end
@@ -46,6 +49,7 @@ def driver_path(options)
             command << '--browser-path'
             command << "\"#{options.binary.gsub('\ ', ' ').gsub(' ', '\ ')}\""
           end
+          command << '--debug' if WebDriver.logger.debug?
 
           location = run(command.join(' '))
           WebDriver.logger.debug("Driver found at #{location}")
@@ -82,8 +86,8 @@ def run(command)
 
           begin
             stdout, stderr, status = Open3.capture3(command)
-            json_output = JSON.parse(stdout)
-            result = json_output['result']['message']
+            json_output = stdout.empty? ? nil : JSON.parse(stdout)
+            result = json_output&.dig('result', 'message')
           rescue StandardError => e
             raise Error::WebDriverError, "Unsuccessful command executed: #{command}", e.message
           end
@@ -93,7 +97,7 @@ def run(command)
           end
 
           json_output['logs'].each do |log|
-            WebDriver.logger.warn(log['message']) if log['level'] == 'WARN'
+            WebDriver.logger.send(log['level'].downcase, log['message'])
           end
 
           result
