Skip to content

Commit a50bfe2

Browse files
authored
[js][bidi] fix addPreloadScript failing tests (#12182)
1 parent ca9d41a commit a50bfe2

2 files changed

Lines changed: 4 additions & 6 deletions

File tree

javascript/node/selenium-webdriver/bidi/scriptManager.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ class ScriptManager {
182182

183183
async addPreloadScript(
184184
functionDeclaration,
185-
argumentValueList = null,
185+
argumentValueList = [],
186186
sandbox = null
187187
) {
188188
const params = {

javascript/node/selenium-webdriver/test/bidi/bidi_test.js

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1050,7 +1050,6 @@ suite(
10501050
result.exceptionDetails.text,
10511051
"SyntaxError: expected expression, got ')'"
10521052
)
1053-
assert.equal(result.exceptionDetails.lineNumber, 285)
10541053
assert.equal(result.exceptionDetails.columnNumber, 39)
10551054
assert.equal(result.exceptionDetails.stackTrace.callFrames.length, 0)
10561055
})
@@ -1191,7 +1190,6 @@ suite(
11911190
result.exceptionDetails.text,
11921191
"SyntaxError: expected expression, got ')'"
11931192
)
1194-
assert.equal(result.exceptionDetails.lineNumber, 251)
11951193
assert.equal(result.exceptionDetails.columnNumber, 39)
11961194
assert.equal(result.exceptionDetails.stackTrace.callFrames.length, 0)
11971195
})
@@ -1568,7 +1566,7 @@ suite(
15681566
await manager.addPreloadScript('() => { window.foo = 1; }')
15691567
await manager.addPreloadScript(
15701568
'() => { window.bar = 2; }',
1571-
null,
1569+
[],
15721570
'sandbox'
15731571
)
15741572

@@ -1612,7 +1610,7 @@ suite(
16121610
await manager.addPreloadScript('() => { window.foo = 42; }')
16131611
await manager.addPreloadScript(
16141612
'() => { window.foo = 50; }',
1615-
null,
1613+
[],
16161614
'sandbox_1'
16171615
)
16181616

@@ -1738,7 +1736,7 @@ suite(
17381736

17391737
let script_2 = await manager.addPreloadScript(
17401738
'() => { window.bar = 2; }',
1741-
null,
1739+
[],
17421740
'sandbox'
17431741
)
17441742

0 commit comments

Comments
 (0)