[py]: Add check=False explicitly to subprocess calls; simplify keys_to_typing

symonk · symonk · commit a0e569b0825e · 2023-07-24T20:10:53.000+01:00
diff --git a/py/selenium/webdriver/common/selenium_manager.py b/py/selenium/webdriver/common/selenium_manager.py
@@ -117,7 +117,7 @@ def run(args: List[str]) -> dict:
         command = " ".join(args)
         logger.debug(f"Executing process: {command}")
         try:
-            completed_proc = subprocess.run(args, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
+            completed_proc = subprocess.run(args, stdout=subprocess.PIPE, stderr=subprocess.PIPE, check=False)
             stdout = completed_proc.stdout.decode("utf-8").rstrip("\n")
             stderr = completed_proc.stderr.decode("utf-8").rstrip("\n")
             output = json.loads(stdout)
diff --git a/py/selenium/webdriver/common/utils.py b/py/selenium/webdriver/common/utils.py
@@ -127,16 +127,13 @@ def is_url_connectable(port: Union[int, str]) -> bool:
 
 def keys_to_typing(value: Iterable[AnyKey]) -> List[str]:
     """Processes the values that will be typed in the element."""
-    _typing: List[str] = []
+    characters: List[str] = []
     for val in value:
         if isinstance(val, Keys):
             # Todo: Does this even work?
-            _typing.append(val)
+            characters.append(val)
         elif isinstance(val, (int, float)):
-            val = str(val)
-            for i in range(len(val)):
-                _typing.append(val[i])
+            characters.extend(str(val))
         else:
-            for i in range(len(val)):
-                _typing.append(val[i])
-    return _typing
+            characters.extend(val)
+    return characters
