add deleteNetworkConditions for chromium (#10323)

slhck · web-flow · commit 9f2290571bc2 · 2022-02-04T19:40:14.000+05:30
This implements the functionality to delete previously set network conditions in Chromium. Fixes #10322
diff --git a/javascript/node/selenium-webdriver/chromium.js b/javascript/node/selenium-webdriver/chromium.js
@@ -92,6 +92,7 @@ const Command = {
   LAUNCH_APP: 'launchApp',
   GET_NETWORK_CONDITIONS: 'getNetworkConditions',
   SET_NETWORK_CONDITIONS: 'setNetworkConditions',
+  DELETE_NETWORK_CONDITIONS: 'deleteNetworkConditions',
   SEND_DEVTOOLS_COMMAND: 'sendDevToolsCommand',
   SEND_AND_GET_DEVTOOLS_COMMAND: 'sendAndGetDevToolsCommand',
   SET_PERMISSION: 'setPermission',
@@ -137,6 +138,11 @@ function configureExecutor(executor, vendorPrefix) {
     'POST',
     '/session/:sessionId/chromium/network_conditions'
   )
+  executor.defineCommand(
+    Command.DELETE_NETWORK_CONDITIONS,
+    'DELETE',
+    '/session/:sessionId/chromium/network_conditions'
+  )
   executor.defineCommand(
     Command.SEND_DEVTOOLS_COMMAND,
     'POST',
@@ -706,6 +712,15 @@ class Driver extends webdriver.WebDriver {
     return this.execute(new command.Command(Command.GET_NETWORK_CONDITIONS))
   }
 
+  /**
+   * Schedules a command to delete Chromium network emulation settings.
+   * @return {!Promise} A promise that will be resolved when network
+   *     emulation settings have been deleted.
+   */
+  deleteNetworkConditions() {
+    return this.execute(new command.Command(Command.DELETE_NETWORK_CONDITIONS))
+  }
+
   /**
    * Schedules a command to set Chromium network emulation settings.
    *
diff --git a/javascript/node/selenium-webdriver/test/chrome/options_test.js b/javascript/node/selenium-webdriver/test/chrome/options_test.js
@@ -156,6 +156,24 @@ test.suite(
         assert.strictEqual(userAgent, 'foo;bar')
       })
 
+      it('can start chromium with network conditions set', async function () {
+        driver = await env.builder().build()
+        await driver.get(test.Pages.ajaxyPage)
+        await driver.setNetworkConditions({
+          offline: true,
+          latency: 0,
+          download_throughput: 0,
+          upload_throughput: 0,
+        })
+        assert.deepStrictEqual(await driver.getNetworkConditions(), {
+          download_throughput: 0,
+          latency: 0,
+          offline: true,
+          upload_throughput: 0,
+        })
+        await driver.deleteNetworkConditions()
+      })
+
       it('can install an extension from path', async function () {
         let options = new chrome.Options().addExtensions(WEBEXTENSION_CRX)
 
