Skip to content

Commit 9e4d3d6

Browse files
[js] Correct ignores in actions tests so they actually work
1 parent 02ba052 commit 9e4d3d6

1 file changed

Lines changed: 9 additions & 11 deletions

File tree

javascript/node/selenium-webdriver/test/actions_test.js

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,11 @@
2020
const assert = require('assert')
2121
const error = require('../lib/error')
2222
const fileServer = require('../lib/test/fileserver')
23-
const test = require('../lib/test')
23+
const { ignore, Pages, suite } = require('../lib/test')
2424
const { Key, Origin } = require('../lib/input')
2525
const { Browser, By, until } = require('..')
2626

27-
test.suite(function (env) {
27+
suite(function (env) {
2828
describe('WebDriver.actions()', function () {
2929
let driver
3030

@@ -90,8 +90,7 @@ test.suite(function (env) {
9090
assert.deepStrictEqual(clicks, [[260, 260]])
9191
})
9292

93-
test
94-
.ignore(env.browsers(Browser.SAFARI))
93+
ignore(env.browsers(Browser.SAFARI))
9594
.it('doubleClick(element)', async function () {
9695
await driver.get(fileServer.whereIs('/data/actions/click.html'))
9796

@@ -160,7 +159,7 @@ test.suite(function (env) {
160159
})
161160

162161
it('can send keys to focused element', async function () {
163-
await driver.get(test.Pages.formPage)
162+
await driver.get(Pages.formPage)
164163

165164
let el = await driver.findElement(By.id('email'))
166165
assert.strictEqual(await el.getAttribute('value'), '')
@@ -173,7 +172,7 @@ test.suite(function (env) {
173172
})
174173

175174
it('can get the property of element', async function () {
176-
await driver.get(test.Pages.formPage)
175+
await driver.get(Pages.formPage)
177176

178177
let el = await driver.findElement(By.id('email'))
179178
assert.strictEqual(await el.getProperty('value'), '')
@@ -186,7 +185,7 @@ test.suite(function (env) {
186185
})
187186

188187
it('can send keys to focused element (with modifiers)', async function () {
189-
await driver.get(test.Pages.formPage)
188+
await driver.get(Pages.formPage)
190189

191190
let el = await driver.findElement(By.id('email'))
192191
assert.strictEqual(await el.getAttribute('value'), '')
@@ -206,7 +205,7 @@ test.suite(function (env) {
206205
})
207206

208207
it('can interact with simple form elements', async function () {
209-
await driver.get(test.Pages.formPage)
208+
await driver.get(Pages.formPage)
210209

211210
let el = await driver.findElement(By.id('email'))
212211
assert.strictEqual(await el.getAttribute('value'), '')
@@ -216,10 +215,9 @@ test.suite(function (env) {
216215
assert.strictEqual(await el.getAttribute('value'), 'foobar')
217216
})
218217

219-
test
220-
.ignore(env.browsers(Browser.SAFARI, Browser.Firefox))
218+
ignore(env.browsers(Browser.FIREFOX, Browser.SAFARI))
221219
.it('can scroll with the wheel input', async function () {
222-
await driver.get(test.Pages.scrollingPage)
220+
await driver.get(Pages.scrollingPage)
223221
let scrollable = await driver.findElement(By.id("scrollable"))
224222

225223
await driver.actions().scroll(0, 0, 5, 10, scrollable).perform()

0 commit comments

Comments
 (0)