[rb] use class method instead of constructor for Options

titusfortner · titusfortner · commit 8dde70295bc8 · 2022-12-24T23:02:41.000-06:00
diff --git a/rb/spec/unit/selenium/webdriver/remote/bridge_spec.rb b/rb/spec/unit/selenium/webdriver/remote/bridge_spec.rb
@@ -67,7 +67,7 @@ module Remote
               .with(any_args, payload)
               .and_return('status' => 200, 'value' => {'sessionId' => 'foo', 'capabilities' => {}})
 
-            bridge.create_session(Chrome::Options.new(args: %w[foo bar]).as_json)
+            bridge.create_session(Options.chrome(args: %w[foo bar]).as_json)
             expect(http).to have_received(:request).with(any_args, payload)
           end
 
diff --git a/rb/spec/unit/selenium/webdriver/remote/driver_spec.rb b/rb/spec/unit/selenium/webdriver/remote/driver_spec.rb
@@ -61,7 +61,7 @@ def expect_request(body: nil, endpoint: nil)
           opts = {args: ['-f']}
           expect_request(body: {capabilities: {alwaysMatch: {browserName: 'chrome', 'goog:chromeOptions': opts}}})
 
-          expect { Driver.new(options: Chrome::Options.new(**opts)) }.not_to raise_exception
+          expect { Driver.new(options: Options.chrome(**opts)) }.not_to raise_exception
         end
 
         context 'with :capabilities' do
@@ -108,7 +108,7 @@ def as_json(*)
             end
 
             it 'with Options instance' do
-              options = Chrome::Options.new(args: ['-f'])
+              options = Options.chrome(args: ['-f'])
               expect_request(body: {capabilities: {alwaysMatch: {browserName: "chrome",
                                                                  'goog:chromeOptions': {args: ['-f']}}}})
 
@@ -126,12 +126,12 @@ def as_json(*)
               expect_request(body: {capabilities: {alwaysMatch: {browserName: "chrome",
                                                                  'goog:chromeOptions': {},
                                                                  'company:key': 'value'}}})
-              expect { Driver.new(capabilities: [Chrome::Options.new, as_json_object.new]) }.not_to raise_exception
+              expect { Driver.new(capabilities: [Options.chrome, as_json_object.new]) }.not_to raise_exception
             end
 
             it 'with Options instance, Capabilities instance and instance of a custom object responding to #as_json' do
               capabilities = Remote::Capabilities.new(browser_name: 'chrome', invalid: 'foobar')
-              options = Chrome::Options.new(args: ['-f'])
+              options = Options.chrome(args: ['-f'])
               expect_request(body: {capabilities: {alwaysMatch: {browserName: "chrome", invalid: 'foobar',
                                                                  'goog:chromeOptions': {args: ['-f']},
                                                                  'company:key': 'value'}}})
