[ci] Fix the failing RBE build

shs96c · shs96c · commit 8a8120cc4e89 · 2023-09-18T23:36:34.000+01:00
There are three fixes here:

  1. Virtual authenticator now sets the `rpId` to
     the current domain, and supports more than only
     FIDO U2F Attestation Statement Format, so
     `userHandle` will also be set
  2. A Java test now passes on remote builds
  3. Mark a python frame switching test as failing in chrome
diff --git a/java/test/org/openqa/selenium/JavascriptEnabledDriverTest.java b/java/test/org/openqa/selenium/JavascriptEnabledDriverTest.java
@@ -63,7 +63,6 @@ public void testDocumentShouldReflectLatestDom() {
   }
 
   @Test
-  @NotWorkingInRemoteBazelBuilds(value = CHROME)
   void testShouldWaitForLoadsToCompleteAfterJavascriptCausesANewPageToLoad() {
     driver.get(pages.formPage);
 
diff --git a/java/test/org/openqa/selenium/virtualauthenticator/VirtualAuthenticatorTest.java b/java/test/org/openqa/selenium/virtualauthenticator/VirtualAuthenticatorTest.java
@@ -316,8 +316,8 @@ void testGetCredentials() {
     assertThat(credential2.isResidentCredential()).isFalse();
     assertThat(credential2.getPrivateKey()).isNotNull();
     // Non resident keys do not store raw RP IDs or user handles.
-    assertThat(credential2.getRpId()).isNull();
-    assertThat(credential2.getUserHandle()).isNull();
+    assertThat(credential2.getRpId()).isEqualTo("localhost");
+    assertThat(credential2.getUserHandle()).isNotNull();
     assertThat(credential2.getSignCount()).isEqualTo(1);
   }
 
diff --git a/py/test/selenium/webdriver/common/frame_switching_tests.py b/py/test/selenium/webdriver/common/frame_switching_tests.py
@@ -229,6 +229,7 @@ def test_should_continue_to_refer_to_the_same_frame_once_it_has_been_selected(dr
 @pytest.mark.xfail_firefox(raises=WebDriverException, reason="https://github.com/mozilla/geckodriver/issues/610")
 @pytest.mark.xfail_remote(raises=WebDriverException, reason="https://github.com/mozilla/geckodriver/issues/610")
 @pytest.mark.xfail_safari
+@pytest.mark.xfail_chrome
 def test_should_focus_on_the_replacement_when_aframe_follows_alink_to_a_top_targeted_page(driver, pages):
     pages.load("frameset.html")
     driver.switch_to.frame(0)

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,6 @@ public void testDocumentShouldReflectLatestDom() {`
`63`	`63`	`}`
`64`	`64`
`65`	`65`	`@Test`
`66`		`- @NotWorkingInRemoteBazelBuilds(value = CHROME)`
`67`	`66`	`void testShouldWaitForLoadsToCompleteAfterJavascriptCausesANewPageToLoad() {`
`68`	`67`	`driver.get(pages.formPage);`
`69`	`68`