Skip to content

Commit 88559df

Browse files
committed
[rb] clarify scroll tests
1 parent 6356ff2 commit 88559df

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

rb/spec/integration/selenium/webdriver/action_builder_spec.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -296,7 +296,7 @@ def in_viewport?(element)
296296
driver.navigate.to url_for('scrolling_tests/frame_with_nested_scrolling_frame_out_of_view.html')
297297

298298
footer = driver.find_element(tag_name: 'footer')
299-
driver.action.scroll(x: 0, y: -50, delta_y: 200, origin: footer).perform
299+
driver.action.scroll(y: -50, delta_y: 200, origin: footer).perform
300300

301301
driver.switch_to.frame(driver.find_element(tag_name: 'iframe'))
302302
checkbox = driver.find_element(name: 'scroll_checkbox')
@@ -312,7 +312,7 @@ def in_viewport?(element)
312312
}.to raise_error(Error::MoveTargetOutOfBoundsError)
313313
end
314314

315-
it 'scrolls from element by given amount with' do
315+
it 'scrolls by given amount' do
316316
driver.navigate.to url_for('scrolling_tests/frame_with_nested_scrolling_frame_out_of_view.html')
317317
footer = driver.find_element(tag_name: 'footer')
318318

@@ -321,7 +321,7 @@ def in_viewport?(element)
321321
expect(in_viewport?(footer)).to eq true
322322
end
323323

324-
it 'scrolls by amount provided' do
324+
it 'scrolls by given amount with offset' do
325325
driver.navigate.to url_for('scrolling_tests/frame_with_nested_scrolling_frame.html')
326326

327327
driver.action.scroll(x: 10, y: 10, delta_y: 200).perform

0 commit comments

Comments
 (0)