Skip to content

Commit 8467a8c

Browse files
authored
[rust] Support for multiple browser names in Selenium Manager (#11352) (#11420)
* [rust] Support for multiple browser names in Selenium Manager (#11352) * [rust] Use vector of broweser name to create a shorter conditional
1 parent 19ffbef commit 8467a8c

1 file changed

Lines changed: 13 additions & 4 deletions

File tree

rust/src/lib.rs

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -288,13 +288,22 @@ pub trait SeleniumManager {
288288
// ----------------------------------------------------------
289289

290290
pub fn get_manager_by_browser(browser_name: String) -> Result<Box<dyn SeleniumManager>, String> {
291-
if browser_name.eq_ignore_ascii_case("chrome") {
291+
let browser_name_lower_case = browser_name.to_ascii_lowercase();
292+
if browser_name_lower_case.eq("chrome") {
292293
Ok(ChromeManager::new())
293-
} else if browser_name.eq_ignore_ascii_case("firefox") {
294+
} else if browser_name.eq("firefox") {
294295
Ok(FirefoxManager::new())
295-
} else if browser_name.eq_ignore_ascii_case("edge") {
296+
} else if vec!["edge", "msedge", "microsoftedge"].contains(&browser_name_lower_case.as_str()) {
296297
Ok(EdgeManager::new())
297-
} else if browser_name.eq_ignore_ascii_case("iexplorer") {
298+
} else if vec![
299+
"iexplorer",
300+
"ie",
301+
"internetexplorer",
302+
"internet-explorer",
303+
"internet_explorer",
304+
]
305+
.contains(&browser_name_lower_case.as_str())
306+
{
298307
Ok(IExplorerManager::new())
299308
} else {
300309
Err(format!("Invalid browser name: {browser_name}"))

0 commit comments

Comments
 (0)