Undo a bug fix that caused a worse bug. (#11666)

mdmintz · web-flow · commit 835ee7ed723c · 2023-02-18T00:14:31.000+01:00
### Undo a bug fix that caused a worse bug. Do to 3f6717d#diff-10fa59c3fd96a0c31762373ca8d7373c0ab669a437ae957b1a17ea1377b20608 a worse bug was allowed to appear that caused deprecation warnings for everyone using ``selenium`` ``4.8.1`` with unittest / pytest. ``DeprecationWarning: keep_alive has been deprecated, please pass in a Service object``, even if not setting ``keep_alive``. This temporary fix will allow the Selenium Team more time to deal with the proper fix for both bugs. (Caused by duplicate calls in Chrome / Chromium ``__init__()`` methods.
diff --git a/py/selenium/webdriver/chromium/webdriver.py b/py/selenium/webdriver/chromium/webdriver.py
@@ -74,7 +74,7 @@ def __init__(
                 DeprecationWarning,
                 stacklevel=2,
             )
-        if keep_alive != DEFAULT_KEEP_ALIVE and isinstance(self, __class__):
+        if keep_alive != DEFAULT_KEEP_ALIVE and type(self) == __class__:
             warnings.warn(
                 "keep_alive has been deprecated, please pass in a Service object", DeprecationWarning, stacklevel=2
             )

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ def __init__(`
`74`	`74`	`DeprecationWarning,`
`75`	`75`	`stacklevel=2,`
`76`	`76`	`)`
`77`		`- if keep_alive != DEFAULT_KEEP_ALIVE and isinstance(self, __class__):`
	`77`	`+ if keep_alive != DEFAULT_KEEP_ALIVE and type(self) == __class__:`
`78`	`78`	`warnings.warn(`
`79`	`79`	`"keep_alive has been deprecated, please pass in a Service object", DeprecationWarning, stacklevel=2`
`80`	`80`	`)`