[grid] Adding tests for flag to disable CDP if needed.

diemol · diemol · commit 7e541ed15766 · 2022-05-24T16:17:29.000+02:00
diff --git a/java/test/org/openqa/selenium/grid/node/config/NodeOptionsTest.java b/java/test/org/openqa/selenium/grid/node/config/NodeOptionsTest.java
@@ -17,14 +17,6 @@
 
 package org.openqa.selenium.grid.node.config;
 
-import static java.util.Collections.emptyMap;
-import static java.util.Collections.emptySet;
-import static java.util.Collections.singletonMap;
-import static org.assertj.core.api.Assertions.assertThat;
-import static org.junit.Assert.fail;
-import static org.junit.Assume.assumeFalse;
-import static org.junit.Assume.assumeTrue;
-
 import com.google.common.collect.ImmutableMap;
 
 import org.assertj.core.api.Condition;
@@ -58,6 +50,14 @@
 import java.util.Map;
 import java.util.Optional;
 
+import static java.util.Collections.emptyMap;
+import static java.util.Collections.emptySet;
+import static java.util.Collections.singletonMap;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.junit.Assert.fail;
+import static org.junit.Assume.assumeFalse;
+import static org.junit.Assume.assumeTrue;
+
 @SuppressWarnings("DuplicatedCode")
 public class NodeOptionsTest {
 
@@ -107,6 +107,12 @@ public void shouldDetectCorrectDriversOnWindows() {
     assertThat(reported).isNot(supporting("safari"));
   }
 
+  @Test
+  public void cdpCanBeDisabled() {
+    Config config = new MapConfig(singletonMap("node", singletonMap("enable-cdp", "false")));
+    NodeOptions nodeOptions = new NodeOptions(config);
+    assertThat(nodeOptions.isCdpEnabled()).isFalse();
+  }
 
   @Test
   public void shouldDetectCorrectDriversOnMac() {
diff --git a/java/test/org/openqa/selenium/grid/node/local/LocalNodeTest.java b/java/test/org/openqa/selenium/grid/node/local/LocalNodeTest.java
@@ -274,4 +274,32 @@ public void nodeDrainsAfterSessionCountIsReached() throws URISyntaxException {
 
     assertThat(localNode.isDraining()).isTrue();
   }
+
+  @Test
+  public void cdpIsDisabledAndResponseCapsShowThat() throws URISyntaxException {
+    Tracer tracer = DefaultTestTracer.createTracer();
+    EventBus bus = new GuavaEventBus();
+    URI uri = new URI("http://localhost:7890");
+    Capabilities stereotype = new ImmutableCapabilities("browserName", "cheese");
+
+    LocalNode.Builder builder = LocalNode.builder(tracer, bus, uri, uri, registrationSecret)
+      .enableCdp(false)
+      .add(stereotype,
+           new TestSessionFactory((id, caps)
+                                    -> new Session(id, uri, stereotype, caps, Instant.now())));
+    LocalNode localNode = builder.build();
+
+    Either<WebDriverException, CreateSessionResponse> response = localNode.newSession(
+      new CreateSessionRequest(
+        ImmutableSet.of(W3C),
+        stereotype,
+        ImmutableMap.of()));
+    assertThat(response.isRight()).isTrue();
+
+    CreateSessionResponse sessionResponse = response.right();
+    Capabilities capabilities = sessionResponse.getSession().getCapabilities();
+    Object cdpEnabled = capabilities.getCapability("se:cdpEnabled");
+    assertThat(cdpEnabled).isNotNull();
+    assertThat(Boolean.parseBoolean(cdpEnabled.toString())).isFalse();
+  }
 }
