[js] use generated selenium manager artifacts for testing

titusfortner · titusfortner · commit 77c00ffe2dcb · 2023-06-05T09:56:48.000-05:00
diff --git a/.bazelrc b/.bazelrc
@@ -55,7 +55,6 @@ build --test_env=GITHUB_ACTIONS
 build --test_env=MOZ_HEADLESS
 build --test_env=PATH  # Remove once browser pinning works
 build --test_env=SELENIUM_BROWSER
-build --test_env=SELENIUM_MANAGER_BASE_PATH
 build --test_env=TRAVIS
 build --test_env=PYTHON_VERSION
 
diff --git a/javascript/node/selenium-webdriver/BUILD.bazel b/javascript/node/selenium-webdriver/BUILD.bazel
@@ -90,6 +90,9 @@ jasmine_node_test(
     local = True,
     templated_args = ["--node_options=--require=$$(rlocation $(rootpath :tools/init_jasmine.js))"],
     deps = [
+        ":manager-linux",
+        ":manager-macos",
+        ":manager-windows",
         "//javascript/node/selenium-webdriver/lib/atoms:find-elements",
         "//javascript/node/selenium-webdriver/lib/atoms:get_attribute",
         "//javascript/node/selenium-webdriver/lib/atoms:is_displayed",
diff --git a/javascript/node/selenium-webdriver/common/seleniumManager.js b/javascript/node/selenium-webdriver/common/seleniumManager.js
@@ -47,12 +47,7 @@ function getBinary() {
   const file =
     directory === 'windows' ? 'selenium-manager.exe' : 'selenium-manager'
 
-  let seleniumManagerBasePath
-  if (process.env.SELENIUM_MANAGER_BASE_PATH) {
-    seleniumManagerBasePath = process.env.SELENIUM_MANAGER_BASE_PATH
-  } else {
-    seleniumManagerBasePath = path.join(__dirname, '..', '/bin')
-  }
+  let seleniumManagerBasePath = path.join(__dirname, '..', '/bin')
 
   const filePath = path.join(seleniumManagerBasePath, directory, file)
 
