[grid] Fixing SessionCapabilitiesMutator tests

diemol · diemol · commit 770acab6f742 · 2023-04-19T22:54:09.000+02:00
diff --git a/java/src/org/openqa/selenium/grid/node/config/SessionCapabilitiesMutator.java b/java/src/org/openqa/selenium/grid/node/config/SessionCapabilitiesMutator.java
@@ -156,7 +156,7 @@ private Map<String, Object> mergeChromiumOptions(Map<String, Object> stereotypeO
         toReturn.put(name, value);
       }
 
-      if (!name.equals("extensions") && !name.equals("args")) {
+      if (!name.equals("binary") && !name.equals("extensions") && !name.equals("args")) {
         toReturn.put(name, value);
       }
     }
diff --git a/java/test/org/openqa/selenium/grid/node/config/SessionCapabilitiesMutatorTest.java b/java/test/org/openqa/selenium/grid/node/config/SessionCapabilitiesMutatorTest.java
@@ -194,7 +194,7 @@ void shouldMergeEdgeSpecificOptionsFromStereotypeAndCaps() {
 
     assertThat(modifiedCapabilities)
       .extractingByKey("ms:edgeOptions").asInstanceOf(MAP)
-      .extractingByKey("binary").isNull();
+      .extractingByKey("binary").isEqualTo("/path/to/binary");
   }
 
   @Test

Original file line number	Diff line number	Diff line change
`@@ -156,7 +156,7 @@ private Map<String, Object> mergeChromiumOptions(Map<String, Object> stereotypeO`
`156`	`156`	`toReturn.put(name, value);`
`157`	`157`	`}`
`158`	`158`
`159`		`- if (!name.equals("extensions") && !name.equals("args")) {`
	`159`	`+ if (!name.equals("binary") && !name.equals("extensions") && !name.equals("args")) {`
`160`	`160`	`toReturn.put(name, value);`
`161`	`161`	`}`
`162`	`162`	`}`
Original file line number	Diff line number	Diff line change
`@@ -194,7 +194,7 @@ void shouldMergeEdgeSpecificOptionsFromStereotypeAndCaps() {`
`194`	`194`
`195`	`195`	`assertThat(modifiedCapabilities)`
`196`	`196`	`.extractingByKey("ms:edgeOptions").asInstanceOf(MAP)`
`197`		`- .extractingByKey("binary").isNull();`
	`197`	`+ .extractingByKey("binary").isEqualTo("/path/to/binary");`
`198`	`198`	`}`
`199`	`199`
`200`	`200`	`@Test`