[bazel] Get python large "auto" tests running on engflow (#12159)

shs96c · web-flow · commit 7497e38c57f6 · 2023-06-06T15:12:52.000+01:00
diff --git a/py/BUILD.bazel b/py/BUILD.bazel
@@ -325,6 +325,7 @@ py_library(
             "--instafail",
         ] + BROWSERS[browser]["args"],
         data = BROWSERS[browser]["data"],
+        env_inherit = ["DISPLAY"],
         tags = [
             "no-sandbox",
         ] + BROWSERS[browser]["tags"],
diff --git a/py/conftest.py b/py/conftest.py
@@ -127,7 +127,7 @@ def fin():
         if driver_class == "WPEWebKit":
             options = get_options(driver_class, request.config)
         if driver_path is not None:
-            kwargs["executable_path"] = driver_path
+            kwargs["service"] = get_service(driver_class, driver_path)
         if options is not None:
             kwargs["options"] = options
 
@@ -169,6 +169,17 @@ def get_options(driver_class, config):
     return options
 
 
+def get_service(driver_class, executable):
+    # Let the default behaviour be used if we don't set the driver executable
+    if not executable:
+        return None
+
+    module = getattr(webdriver, driver_class.lower())
+    service = module.service.Service(executable_path=executable)
+
+    return service
+
+
 @pytest.fixture(scope="session", autouse=True)
 def stop_driver(request):
     def fin():
diff --git a/py/private/browsers.bzl b/py/private/browsers.bzl
@@ -17,6 +17,8 @@ chrome_args = select({
     "@selenium//common:use_pinned_linux_chrome": [
         "--driver-binary=$(location @linux_chromedriver//:chromedriver)",
         "--browser-binary=$(location @linux_chrome//:chrome-linux/chrome)",
+        "--browser-args=--disable-dev-shm-usage",
+        "--browser-args=--no-sandbox",
     ],
     "@selenium//common:use_pinned_macos_chrome": [
         "--driver-binary=$(location @mac_chromedriver//:chromedriver)",
