Use class' class loader when looking up HttpClient factory. (#10232)

dennisoelkers · web-flow · commit 74634060ce8a · 2022-01-08T23:20:40.000+01:00
Prior to this change, `HttpClient.Factory.create` was using
`ServiceLoader.load` without passing in a class loader explicitly. In
this case, `ServiceLoader` is using the current thread's default class
loader to resolve the specified class name's service.

In projects with a plugin system, this can lead to problems, when
selenium dependencies are part of a jar file that is not on the class
path the application was started with. For these projects, using
selenium results in a `ClassNotFoundException` when the first remote
call is performed.

To fix this, using the class loader of the factory interface would be
beneficial. In projects without a plugin architecture, it will mostly be
identical with the class loader of the current thread, in other cases
there is very high chance that the service which is to be loaded can be
resolved through the class loader of `HttpClient.Factory`.
diff --git a/java/src/org/openqa/selenium/remote/http/HttpClient.java b/java/src/org/openqa/selenium/remote/http/HttpClient.java
@@ -48,7 +48,7 @@ interface Factory {
      * @throws IllegalStateException if more than one implementation with the given name can be found
      */
     static Factory create(String name) {
-      ServiceLoader<HttpClient.Factory> loader = ServiceLoader.load(HttpClient.Factory.class);
+      ServiceLoader<HttpClient.Factory> loader = ServiceLoader.load(HttpClient.Factory.class, HttpClient.Factory.class.getClassLoader());
       Set<Factory> factories = StreamSupport.stream(loader.spliterator(), true)
           .filter(p -> p.getClass().isAnnotationPresent(HttpClientName.class))
           .filter(p -> name.equals(p.getClass().getAnnotation(HttpClientName.class).value()))
