Fix mutating headers in intercepted request

p0deje · p0deje · commit 7033cb4eb570 · 2022-03-30T12:20:17.000-07:00
diff --git a/rb/BUILD.bazel b/rb/BUILD.bazel
@@ -398,6 +398,7 @@ ruby_test(
         "requires-network",
     ],
     deps = [
+        ":bidi",
         ":chrome",
         ":edge",
         ":firefox",
diff --git a/rb/lib/selenium/webdriver/devtools/request.rb b/rb/lib/selenium/webdriver/devtools/request.rb
@@ -35,7 +35,7 @@ def self.from(id, params)
             id: id,
             url: params.dig('request', 'url'),
             method: params.dig('request', 'method'),
-            headers: params.dig('request', 'headers'),
+            headers: params.dig('request', 'headers').dup,
             post_data: params.dig('request', 'postData')
           )
         end
diff --git a/rb/spec/unit/selenium/webdriver/devtools/request_spec.rb b/rb/spec/unit/selenium/webdriver/devtools/request_spec.rb
@@ -0,0 +1,39 @@
+# frozen_string_literal: true
+
+# Licensed to the Software Freedom Conservancy (SFC) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The SFC licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+require File.expand_path('../spec_helper', __dir__)
+
+module Selenium
+  module WebDriver
+    class DevTools
+      describe Request do
+        describe '.from' do
+          it 'duplicates headers for immutability' do
+            params = {'request' => {'headers' => {}}}
+            a = Request.from(1, params)
+            b = Request.from(1, params)
+
+            b.headers['foo'] = 'bar'
+            expect(a).not_to eq(b)
+          end
+        end
+      end # Request
+    end # DevTools
+  end # WebDriver
+end # Selenium

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ def self.from(id, params)`
`35`	`35`	`id: id,`
`36`	`36`	`url: params.dig('request', 'url'),`
`37`	`37`	`method: params.dig('request', 'method'),`
`38`		`- headers: params.dig('request', 'headers'),`
	`38`	`+ headers: params.dig('request', 'headers').dup,`
`39`	`39`	`post_data: params.dig('request', 'postData')`
`40`	`40`	`)`
`41`	`41`	`end`