[rb] Using json output with Selenium Manager

diemol · diemol · commit 6dad428a0945 · 2023-03-21T13:22:48.000+01:00
Work done for #11365
diff --git a/rb/lib/selenium/webdriver/common/selenium_manager.rb b/rb/lib/selenium/webdriver/common/selenium_manager.rb
@@ -37,7 +37,7 @@ def driver_path(options)
             raise ArgumentError, "SeleniumManager requires a WebDriver::Options instance, not a #{options.inspect}"
           end
 
-          command = [binary, '--browser', options.browser_name]
+          command = [binary, '--browser', options.browser_name, '--output', 'json']
           if options.browser_version
             command << '--browser-version'
             command << options.browser_version
@@ -82,15 +82,21 @@ def run(command)
 
           begin
             stdout, stderr, status = Open3.capture3(command)
+            json_output = JSON.parse(stdout)
+            result = json_output['result']['message']
           rescue StandardError => e
             raise Error::WebDriverError, "Unsuccessful command executed: #{command}", e.message
           end
 
           if status.exitstatus.positive?
-            raise Error::WebDriverError, "Unsuccessful command executed: #{command}\n#{stdout}#{stderr}"
+            raise Error::WebDriverError, "Unsuccessful command executed: #{command}\n#{result}#{stderr}"
           end
 
-          stdout.split("\n").last.gsub("INFO\t", '')
+          json_output['logs'].each do |log|
+            WebDriver.logger.warn(log['message']) if log['level'] == 'WARN'
+          end
+
+          result
         end
       end
     end # SeleniumManager
diff --git a/rb/spec/unit/selenium/webdriver/common/selenium_manager_spec.rb b/rb/spec/unit/selenium/webdriver/common/selenium_manager_spec.rb
@@ -85,7 +85,7 @@ module WebDriver
 
           described_class.driver_path(Options.chrome)
 
-          expect(described_class).to have_received(:run).with('selenium-manager --browser chrome')
+          expect(described_class).to have_received(:run).with('selenium-manager --browser chrome --output json')
         end
 
         it 'uses browser version if specified' do
@@ -96,7 +96,8 @@ module WebDriver
 
           described_class.driver_path(options)
 
-          expect(described_class).to have_received(:run).with('selenium-manager --browser chrome --browser-version 1')
+          expect(described_class).to have_received(:run)
+            .with('selenium-manager --browser chrome --output json --browser-version 1')
         end
 
         it 'uses browser location if specified' do
@@ -108,7 +109,7 @@ module WebDriver
           described_class.driver_path(options)
 
           expect(described_class).to have_received(:run)
-            .with('selenium-manager --browser chrome --browser-path "/path/to/browser"')
+            .with('selenium-manager --browser chrome --output json --browser-path "/path/to/browser"')
         end
 
         it 'properly escapes plain spaces in browser location' do
@@ -120,7 +121,7 @@ module WebDriver
           described_class.driver_path(options)
 
           expect(described_class).to have_received(:run)
-            .with('selenium-manager --browser chrome --browser-path "/path\ to/the/browser"')
+            .with('selenium-manager --browser chrome --output json --browser-path "/path\ to/the/browser"')
         end
 
         it 'properly escapes escaped spaces in browser location' do
@@ -132,7 +133,7 @@ module WebDriver
           described_class.driver_path(options)
 
           expect(described_class).to have_received(:run)
-            .with('selenium-manager --browser chrome --browser-path "/path\ to/the/browser"')
+            .with('selenium-manager --browser chrome --output json --browser-path "/path\ to/the/browser"')
         end
       end
     end
