[dotnet] Avoid try/catch while working with known types in Selenium Manager (#12051)

nvborisenko · diemol · web-flow · commit 69ccfe4903fd · 2023-05-17T09:43:51.000+02:00
Avoid try/catch while working with known types

Co-authored-by: Diego Molina &lt;diemol@users.noreply.github.com&gt;
diff --git a/dotnet/src/webdriver/SeleniumManager.cs b/dotnet/src/webdriver/SeleniumManager.cs
@@ -53,22 +53,22 @@ static SeleniumManager()
 #if NET45 || NET46 || NET47
                 binary = "selenium-manager/windows/selenium-manager.exe";
 #else
-                if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
-                {
-                    binary = "selenium-manager/windows/selenium-manager.exe";
-                }
-                else if (RuntimeInformation.IsOSPlatform(OSPlatform.Linux))
-                {
-                    binary = "selenium-manager/linux/selenium-manager";
-                }
-                else if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
-                {
-                    binary = "selenium-manager/macos/selenium-manager";
-                }
-                else
-                {
-                    throw new WebDriverException("Selenium Manager did not find supported operating system");
-                }
+            if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
+            {
+                binary = "selenium-manager/windows/selenium-manager.exe";
+            }
+            else if (RuntimeInformation.IsOSPlatform(OSPlatform.Linux))
+            {
+                binary = "selenium-manager/linux/selenium-manager";
+            }
+            else if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
+            {
+                binary = "selenium-manager/macos/selenium-manager";
+            }
+            else
+            {
+                throw new WebDriverException("Selenium Manager did not find supported operating system");
+            }
 #endif
 
             binaryFullPath = Path.Combine(currentDirectory, binary);
@@ -111,14 +111,11 @@ private static string BrowserBinary(DriverOptions options)
             string[] vendorOptionsCapabilities = { "moz:firefoxOptions", "goog:chromeOptions", "ms:edgeOptions" };
             foreach (string vendorOptionsCapability in vendorOptionsCapabilities)
             {
-                try
-                {
-                    Dictionary<string, object> vendorOptions = capabilities.GetCapability(vendorOptionsCapability) as Dictionary<string, object>;
-                    return vendorOptions["binary"] as string;
-                }
-                catch (Exception)
+                IDictionary<string, object> vendorOptions = capabilities.GetCapability(vendorOptionsCapability) as IDictionary<string, object>;
+
+                if (vendorOptions != null && vendorOptions.TryGetValue("binary", out object browserBinaryPath))
                 {
-                    // no-op, it would be ideal to at least log the exception but the C# do not log anything at the moment 
+                    return browserBinaryPath as string;
                 }
             }
 
