[rb] allow updating service state

titusfortner · titusfortner · commit 613207c2f7e9 · 2022-12-12T07:31:31.000-08:00
diff --git a/rb/lib/selenium/webdriver/common/service.rb b/rb/lib/selenium/webdriver/common/service.rb
@@ -56,8 +56,8 @@ def driver_path=(path)
         end
       end
 
-      attr_accessor :host
-      attr_reader :executable_path, :port, :extra_args
+      attr_accessor :host, :executable_path, :port, :args
+      alias_method :extra_args, :args
 
       #
       # End users should use a class method for the desired driver, rather than using this directly.
@@ -74,7 +74,7 @@ def initialize(path: nil, port: nil, args: nil)
         @host = Platform.localhost
         @port = Integer(port)
 
-        @extra_args = args.is_a?(Hash) ? extract_service_args(args) : args
+        @args = args.is_a?(Hash) ? extract_service_args(args) : args
 
         raise Error::WebDriverError, "invalid port: #{@port}" if @port < 1
       end
diff --git a/rb/lib/selenium/webdriver/common/service_manager.rb b/rb/lib/selenium/webdriver/common/service_manager.rb
@@ -40,7 +40,7 @@ def initialize(config)
         @executable_path = config.executable_path
         @host = Platform.localhost
         @port = config.port
-        @extra_args = config.extra_args
+        @extra_args = config.args
         @shutdown_supported = config.shutdown_supported
 
         raise Error::WebDriverError, "invalid port: #{@port}" if @port < 1
diff --git a/rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb b/rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb
@@ -205,7 +205,9 @@ def ie_options(**opts)
 
         def chrome_driver(options: nil, **opts)
           service_opts = {}
-          service_opts[:args] = ['--disable-build-check'] if ENV['DISABLE_BUILD_CHECK']
+          service_opts[:args] = []
+          service_opts[:args] << '--disable-build-check' if ENV['DISABLE_BUILD_CHECK']
+          service_opts[:args]  << '--verbose' if WebDriver.logger.level == :debug
           service = WebDriver::Service.chrome(**service_opts)
           WebDriver::Driver.for(:chrome, options: options, service: service, **opts)
         end
@@ -218,7 +220,9 @@ def chrome_options(**opts)
 
         def edge_driver(options: nil, **opts)
           service_opts = {}
-          service_opts[:args] = ['--disable-build-check'] if ENV['DISABLE_BUILD_CHECK']
+          service_opts[:args] = []
+          service_opts[:args] << '--disable-build-check' if ENV['DISABLE_BUILD_CHECK']
+          service_opts[:args] << '--verbose' if WebDriver.logger.level == :debug
           service = WebDriver::Service.edge(**service_opts)
           WebDriver::Driver.for(:edge, options: options, service: service, **opts)
         end
