Skip to content

Commit 482d5a4

Browse files
[py] Removed desired capabilities from handshake code (#10494)
* [py] Removed desired capabilities from handshake code Fixes #10264 Co-authored-by: David Burns <[email protected]>
1 parent dad6f8c commit 482d5a4

2 files changed

Lines changed: 3 additions & 6 deletions

File tree

py/selenium/webdriver/remote/webdriver.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -355,8 +355,7 @@ def start_session(self, capabilities: dict, browser_profile=None) -> None:
355355
else:
356356
capabilities.update({'firefox_profile': browser_profile.encoded})
357357
w3c_caps = _make_w3c_caps(capabilities)
358-
parameters = {"capabilities": w3c_caps,
359-
"desiredCapabilities": capabilities}
358+
parameters = {"capabilities": w3c_caps}
360359
response = self.execute(Command.NEW_SESSION, parameters)
361360
if 'sessionId' not in response:
362361
response = response['value']

py/test/unit/selenium/webdriver/remote/new_session_tests.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,7 @@ def test_converts_oss_capabilities_to_w3c(mocker):
3232
oss_caps = {'platform': 'WINDOWS', 'version': '11', 'acceptSslCerts': True}
3333
w3c_caps = {'platformName': 'windows', 'browserVersion': '11', 'acceptInsecureCerts': True}
3434
WebDriver(desired_capabilities=deepcopy(oss_caps))
35-
expected_params = {'capabilities': {'firstMatch': [{}], 'alwaysMatch': w3c_caps},
36-
'desiredCapabilities': oss_caps}
35+
expected_params = {'capabilities': {'firstMatch': [{}], 'alwaysMatch': w3c_caps}}
3736
mock.assert_called_with(Command.NEW_SESSION, expected_params)
3837

3938

@@ -42,8 +41,7 @@ def test_converts_proxy_type_value_to_lowercase_for_w3c(mocker):
4241
oss_caps = {'proxy': {'proxyType': 'MANUAL', 'httpProxy': 'foo'}}
4342
w3c_caps = {'proxy': {'proxyType': 'manual', 'httpProxy': 'foo'}}
4443
WebDriver(desired_capabilities=deepcopy(oss_caps))
45-
expected_params = {'capabilities': {'firstMatch': [{}], 'alwaysMatch': w3c_caps},
46-
'desiredCapabilities': oss_caps}
44+
expected_params = {'capabilities': {'firstMatch': [{}], 'alwaysMatch': w3c_caps}}
4745
mock.assert_called_with(Command.NEW_SESSION, expected_params)
4846

4947

0 commit comments

Comments
 (0)