[rust] simplify clear_metadata() body (#11862)

iampopovich · diemol · web-flow · commit 42632b4b3088 · 2023-04-05T18:18:57.000+02:00
simplify clear_metadata() body

Co-authored-by: Diego Molina &lt;diemol@users.noreply.github.com&gt;
diff --git a/rust/src/main.rs b/rust/src/main.rs
@@ -111,7 +111,7 @@ fn main() {
     }
 
     if cli.clear_metadata {
-        clear_metadata(&log)
+        clear_metadata(&log);
     }
 
     let browser_name: String = cli.browser.unwrap_or_default();
diff --git a/rust/src/metadata.rs b/rust/src/metadata.rs
@@ -19,6 +19,7 @@ use std::fs;
 use std::fs::File;
 use std::path::PathBuf;
 use std::time::{SystemTime, UNIX_EPOCH};
+use std::io::Error;
 
 use serde::{Deserialize, Serialize};
 
@@ -155,14 +156,10 @@ pub fn write_metadata(metadata: &Metadata, log: &Logger) {
     .unwrap();
 }
 
-pub fn clear_metadata(log: &Logger) {
+pub fn clear_metadata(log: &Logger) -> Result<(), Error> {
     let metadata_path = get_metadata_path();
-    log.trace(format!(
-        "Deleting metadata file {}",
-        metadata_path.display()
-    ));
-    match fs::remove_file(metadata_path) {
-        Ok(()) => log.trace("Metadata file was deleted".to_string()),
-        Err(err) => log.warn(format!("Metadata file deleting invoked an error: {}", err)),
-    }
+    log.trace(format!("Deleting metadata file {}", metadata_path.display()));
+    fs::remove_file(metadata_path)?;
+    log.trace("Metadata file was deleted".to_string());
+    Ok(())
 }

Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,7 @@ fn main() {`
`111`	`111`	`}`
`112`	`112`
`113`	`113`	`if cli.clear_metadata {`
`114`		`- clear_metadata(&log)`
	`114`	`+ clear_metadata(&log);`
`115`	`115`	`}`
`116`	`116`
`117`	`117`	`let browser_name: String = cli.browser.unwrap_or_default();`