Fix "NoReturn" type-hinnts. (#10120)

cpburnz · web-flow · commit 41a34dfbdfc7 · 2021-12-24T16:00:16.000-06:00
The [NoReturn](https://docs.python.org/3/library/typing.html#typing.NoReturn) type-hint in Python indicates the function never returns (e.g., it always raises an exception). These methods are incorrectly marked as `NoReturn` when they in fact return no value (`None`), and should by hinted using `None`.
diff --git a/py/selenium/webdriver/common/options.py b/py/selenium/webdriver/common/options.py
@@ -16,7 +16,6 @@
 # under the License.
 
 from abc import ABCMeta, abstractmethod
-from typing import NoReturn
 from selenium.webdriver.common.proxy import Proxy
 from selenium.common.exceptions import InvalidArgumentException
 
@@ -48,7 +47,7 @@ def browser_version(self) -> str:
         return self._caps["browserVersion"]
 
     @browser_version.setter
-    def browser_version(self, version: str) -> NoReturn:
+    def browser_version(self, version: str) -> None:
         """
         Requires the major version of the browser to match provided value:
         https://w3c.github.io/webdriver/#dfn-browser-version
@@ -65,7 +64,7 @@ def platform_name(self) -> str:
         return self._caps["platformName"]
 
     @platform_name.setter
-    def platform_name(self, platform: str) -> NoReturn:
+    def platform_name(self, platform: str) -> None:
         """
         Requires the platform to match the provided value: https://w3c.github.io/webdriver/#dfn-platform-name
 
@@ -81,7 +80,7 @@ def page_load_strategy(self) -> str:
         return self._caps["pageLoadStrategy"]
 
     @page_load_strategy.setter
-    def page_load_strategy(self, strategy: str) -> NoReturn:
+    def page_load_strategy(self, strategy: str) -> None:
         """
         Determines the point at which a navigation command is returned:
         https://w3c.github.io/webdriver/#dfn-table-of-page-load-strategies
@@ -101,7 +100,7 @@ def unhandled_prompt_behavior(self) -> str:
         return self._caps["unhandledPromptBehavior"]
 
     @unhandled_prompt_behavior.setter
-    def unhandled_prompt_behavior(self, behavior: str) -> NoReturn:
+    def unhandled_prompt_behavior(self, behavior: str) -> None:
         """
         How the driver should respond when an alert is present and the command sent is not handling the alert:
         https://w3c.github.io/webdriver/#dfn-table-of-page-load-strategies
@@ -122,7 +121,7 @@ def timeouts(self) -> dict:
         return self._caps["timeouts"]
 
     @timeouts.setter
-    def timeouts(self, timeouts: dict) -> NoReturn:
+    def timeouts(self, timeouts: dict) -> None:
         """
         How long the driver should wait for actions to complete before returning an error
         https://w3c.github.io/webdriver/#timeouts
@@ -159,7 +158,7 @@ def accept_insecure_certs(self) -> bool:
         return self._caps.get('acceptInsecureCerts')
 
     @accept_insecure_certs.setter
-    def accept_insecure_certs(self, value: bool) -> NoReturn:
+    def accept_insecure_certs(self, value: bool) -> None:
         """
         Whether untrusted and self-signed TLS certificates are implicitly trusted:
         https://w3c.github.io/webdriver/#dfn-insecure-tls-certificates
