[js] add name of what is being executed to large JS executions

titusfortner · titusfortner · commit 3e9d64ddb821 · 2023-01-04T09:41:59.000-06:00
diff --git a/javascript/node/selenium-webdriver/lib/http.js b/javascript/node/selenium-webdriver/lib/http.js
@@ -182,14 +182,14 @@ class InternalTypeError extends TypeError {}
  * @param params
  * @return {!Command} The transformed command to execute.
  */
-function toExecuteAtomCommand(command, atom, ...params) {
+function toExecuteAtomCommand(command, atom, name, ...params) {
   if (typeof atom !== 'function') {
     throw new InternalTypeError('atom is not a function: ' + typeof atom)
   }
 
   return new cmd.Command(cmd.Name.EXECUTE_SCRIPT)
     .setParameter('sessionId', command.getParameter('sessionId'))
-    .setParameter('script', `return (${atom}).apply(null, arguments)`)
+    .setParameter('script', `/* ${name} */return (${atom}).apply(null, arguments)`)
     .setParameter(
       'args',
       params.map((param) => command.getParameter(param))
@@ -252,7 +252,7 @@ const W3C_COMMAND_MAP = new Map([
   [
     cmd.Name.FIND_ELEMENTS_RELATIVE,
     (cmd) => {
-      return toExecuteAtomCommand(cmd, Atom.FIND_ELEMENTS, 'args')
+      return toExecuteAtomCommand(cmd, Atom.FIND_ELEMENTS, 'findElements', 'args')
     },
   ],
   [
@@ -272,7 +272,7 @@ const W3C_COMMAND_MAP = new Map([
   [
     cmd.Name.GET_ELEMENT_ATTRIBUTE,
     (cmd) => {
-      return toExecuteAtomCommand(cmd, Atom.GET_ATTRIBUTE, 'id', 'name')
+      return toExecuteAtomCommand(cmd, Atom.GET_ATTRIBUTE, 'getAttribute', 'id', 'name')
     },
   ],
   [
@@ -308,7 +308,7 @@ const W3C_COMMAND_MAP = new Map([
   [
     cmd.Name.IS_ELEMENT_DISPLAYED,
     (cmd) => {
-      return toExecuteAtomCommand(cmd, Atom.IS_DISPLAYED, 'id')
+      return toExecuteAtomCommand(cmd, Atom.IS_DISPLAYED, 'isDisplayed', 'id')
     },
   ],
 
diff --git a/javascript/node/selenium-webdriver/lib/webdriver.js b/javascript/node/selenium-webdriver/lib/webdriver.js
@@ -2905,7 +2905,7 @@ class WebElement {
    */
   submit() {
     const script =
-      'var form = arguments[0];\n' +
+      '/* submitForm */var form = arguments[0];\n' +
       'while (form.nodeName != "FORM" && form.parentNode) {\n' +
       '  form = form.parentNode;\n' +
       '}\n' +
