extending WebDriverException (#11727)

MohabMohie · web-flow · commit 3179985c2c22 · 2023-03-03T12:43:50.000+01:00
* extending WebDriverException - fixes #11712 - fixes #10833 - as per https://www.selenium.dev/meetings/2022/tlc-08-17/#proposals * adding new test class * Delete InvalidSelectorTest.java * Update ElementFindingTest.java updating failing tests
diff --git a/java/src/org/openqa/selenium/InvalidSelectorException.java b/java/src/org/openqa/selenium/InvalidSelectorException.java
@@ -25,7 +25,7 @@
  * errors, or a compound class name passed as an argument to By.className(),
  * or the expression does not select WebElements (e.g. "count(//input)").
  */
-public class InvalidSelectorException extends NoSuchElementException {
+public class InvalidSelectorException extends WebDriverException {
 
   private static final String SUPPORT_URL =
     BASE_SUPPORT_URL + "#invalid_selector_exception";
diff --git a/java/test/org/openqa/selenium/ElementFindingTest.java b/java/test/org/openqa/selenium/ElementFindingTest.java
@@ -103,15 +103,15 @@ void testShouldNotBeAbleToLocateByIdMultipleElementsThatDoNotExist() {
   @Test
   void testFindingASingleElementByEmptyIdShouldThrow() {
     driver.get(pages.formPage);
-    assertThatExceptionOfType(NoSuchElementException.class)
+    assertThatExceptionOfType(InvalidSelectorException.class)
         .isThrownBy(() -> driver.findElement(By.id("")));
   }
 
   @Test
   @NotYetImplemented(HTMLUNIT)
   public void testFindingMultipleElementsByEmptyIdShouldThrow() {
     driver.get(pages.formPage);
-    assertThatExceptionOfType(NoSuchElementException.class)
+    assertThatExceptionOfType(InvalidSelectorException.class)
         .isThrownBy(() -> driver.findElements(By.id("")));
   }
 
@@ -231,14 +231,14 @@ void testShouldNotBeAbleToLocateByTagNameMultipleElementsThatDoNotExist() {
   @Test
   void testFindingASingleElementByEmptyTagNameShouldThrow() {
     driver.get(pages.formPage);
-    assertThatExceptionOfType(NoSuchElementException.class)
+    assertThatExceptionOfType(InvalidSelectorException.class)
         .isThrownBy(() -> driver.findElement(By.tagName("")));
   }
 
   @Test
   void testFindingMultipleElementsByEmptyTagNameShouldThrow() {
     driver.get(pages.formPage);
-    assertThatExceptionOfType(NoSuchElementException.class)
+    assertThatExceptionOfType(InvalidSelectorException.class)
         .isThrownBy(() -> driver.findElements(By.tagName("")));
   }
 
@@ -320,28 +320,28 @@ void testShouldNotFindElementByClassWhenTheNameQueriedIsShorterThanCandidateName
   @Test
   void testFindingASingleElementByEmptyClassNameShouldThrow() {
     driver.get(pages.xhtmlTestPage);
-    assertThatExceptionOfType(NoSuchElementException.class)
+    assertThatExceptionOfType(InvalidSelectorException.class)
         .isThrownBy(() -> driver.findElement(By.className("")));
   }
 
   @Test
   void testFindingMultipleElementsByEmptyClassNameShouldThrow() {
     driver.get(pages.xhtmlTestPage);
-    assertThatExceptionOfType(NoSuchElementException.class)
+    assertThatExceptionOfType(InvalidSelectorException.class)
         .isThrownBy(() -> driver.findElements(By.className("")));
   }
 
   @Test
   void testFindingASingleElementByCompoundClassNameShouldThrow() {
     driver.get(pages.xhtmlTestPage);
-    assertThatExceptionOfType(NoSuchElementException.class)
+    assertThatExceptionOfType(InvalidSelectorException.class)
         .isThrownBy(() -> driver.findElement(By.className("a b")));
   }
 
   @Test
   void testFindingMultipleElementsByCompoundClassNameShouldThrow() {
     driver.get(pages.xhtmlTestPage);
-    assertThatExceptionOfType(NoSuchElementException.class)
+    assertThatExceptionOfType(InvalidSelectorException.class)
         .isThrownBy(() -> driver.findElements(By.className("a b")));
   }
 
@@ -572,28 +572,28 @@ void testShouldNotFindElementsByCssSelectorWhenThereIsNoSuchElement() {
   @Test
   void testFindingASingleElementByEmptyCssSelectorShouldThrow() {
     driver.get(pages.xhtmlTestPage);
-    assertThatExceptionOfType(NoSuchElementException.class)
+    assertThatExceptionOfType(InvalidSelectorException.class)
         .isThrownBy(() -> driver.findElement(By.cssSelector("")));
   }
 
   @Test
   void testFindingMultipleElementsByEmptyCssSelectorShouldThrow() {
     driver.get(pages.xhtmlTestPage);
-    assertThatExceptionOfType(NoSuchElementException.class)
+    assertThatExceptionOfType(InvalidSelectorException.class)
         .isThrownBy(() -> driver.findElements(By.cssSelector("")));
   }
 
   @Test
   void testFindingASingleElementByInvalidCssSelectorShouldThrow() {
     driver.get(pages.xhtmlTestPage);
-    assertThatExceptionOfType(NoSuchElementException.class)
+    assertThatExceptionOfType(InvalidSelectorException.class)
         .isThrownBy(() -> driver.findElement(By.cssSelector("//a/b/c[@id='1']")));
   }
 
   @Test
   void testFindingMultipleElementsByInvalidCssSelectorShouldThrow() {
     driver.get(pages.xhtmlTestPage);
-    assertThatExceptionOfType(NoSuchElementException.class)
+    assertThatExceptionOfType(InvalidSelectorException.class)
         .isThrownBy(() -> driver.findElements(By.cssSelector("//a/b/c[@id='1']")));
   }
 
