[py]: minor types, avoid import names for variables, simplify int or float checks in keys_to_typing

symonk · symonk · commit 2e059e031460 · 2022-09-02T20:00:11.000+01:00
diff --git a/py/selenium/webdriver/common/utils.py b/py/selenium/webdriver/common/utils.py
@@ -136,15 +136,16 @@ def is_url_connectable(port: Union[int, str]) -> bool:
 
 def keys_to_typing(value: Iterable[AnyKey]) -> List[str]:
     """Processes the values that will be typed in the element."""
-    typing: List[str] = []
+    _typing: List[str] = []
     for val in value:
         if isinstance(val, Keys):
-            typing.append(val)
-        elif isinstance(val, int) or isinstance(val, float):
+            # Todo: Does this even work?
+            _typing.append(val)
+        elif isinstance(val, (int, float)):
             val = str(val)
             for i in range(len(val)):
-                typing.append(val[i])
+                _typing.append(val[i])
         else:
             for i in range(len(val)):
-                typing.append(val[i])
-    return typing
+                _typing.append(val[i])
+    return _typing
diff --git a/py/selenium/webdriver/remote/webelement.py b/py/selenium/webdriver/remote/webelement.py
@@ -443,7 +443,7 @@ def find_elements(self, by=By.ID, value=None) -> list[WebElement]:
         return self._execute(Command.FIND_CHILD_ELEMENTS,
                              {"using": by, "value": value})['value']
 
-    def __hash__(self):
+    def __hash__(self) -> int:
         return int(md5_hash(self._id.encode('utf-8')).hexdigest(), 16)
 
     def _upload(self, filename):
