Use Bazel for running Rust tests (#11852)

p0deje · diemol · bonigarcia · web-flow · commit 2b3ad21fe9e9 · 2023-04-17T11:51:32.000+02:00
* Use Bazel for running Rust tests

* Add Rust build/test targets to README.md

[skip ci]

* Crate tests should be unsandboxed

---------

Co-authored-by: Diego Molina &lt;diemol@users.noreply.github.com&gt;
Co-authored-by: Boni García &lt;boni.garcia@uc3m.es&gt;
diff --git a/.github/workflows/ci-rust.yml b/.github/workflows/ci-rust.yml
@@ -5,28 +5,27 @@ on:
   workflow_dispatch:
 
 jobs:
-  test:
-    name: Test
+  build:
+    name: Build
+    uses: ./.github/workflows/bazel.yml
+    with:
+      name: Build
+      cache-key: rust-build
+      run: bazel build //rust:selenium-manager
+
+  tests:
+    name: Tests
+    needs: build
+    uses: ./.github/workflows/bazel.yml
     strategy:
+      fail-fast: false
       matrix:
-        os:
-          - ubuntu-latest
-          - windows-latest
-          - macos-latest
-        rust:
-          - stable
-    runs-on: ${{ matrix.os }}
-    env:
-      RUST_BACKTRACE: 1
-    steps:
-    - name: Checkout repository
-      uses: actions/checkout@v3
-    - name: Install Rust toolchain
-      uses: actions-rs/toolchain@v1
-      with:
-        toolchain: ${{ matrix.rust }}
-    - name: Run tests
-      run: |
-        cd rust
-        cargo build
-        cargo test -- --nocapture
+        include:
+          - os: macos
+          - os: ubuntu
+          - os: windows
+    with:
+      name: Tests (${{ matrix.os }})
+      cache-key: rust-test
+      os: ${{ matrix.os }}
+      run: bazel test --test_env=RUST_BACKTRACE=1 --flaky_test_attempts=3 //rust/...
diff --git a/README.md b/README.md
@@ -298,6 +298,16 @@ More information about running Selenium's .NET tests can be found in this [READM
 
 </details>
 
+#### Rust
+<details>
+<summary>Click to see Rust Build Steps</summary>
+
+Targets:
+
+| Command                               | Description                         |
+|---------------------------------------|-------------------------------------|
+| `bazel build //rust:selenium-manager` | Build selenium-manager binary       |
+| `bazel test //rust/...`               | Run both unit and integration tests |
 
 ### Build Details
 
diff --git a/rust/BUILD.bazel b/rust/BUILD.bazel
@@ -1,5 +1,5 @@
 load("@crates//:defs.bzl", "all_crate_deps")
-load("@rules_rust//rust:defs.bzl", "rust_binary", "rust_library")
+load("@rules_rust//rust:defs.bzl", "rust_binary", "rust_library", "rust_test")
 
 rust_binary(
     # Yes, this name is very similar to the library. Note the dash
@@ -23,3 +23,29 @@ rust_library(
     edition = "2021",
     deps = all_crate_deps(normal = True),
 )
+
+rust_test(
+    name = "unit",
+    srcs = glob(["src/**/*.rs"]),
+    crate = ":selenium_manager",
+    tags = ["no-sandbox"],
+)
+
+[
+    rust_test(
+        name = file[:-3],
+        srcs = [file],
+        data = [":selenium-manager"],
+        edition = "2021",
+        tags = [
+            "exclusive",
+            "no-sandbox",
+            "requires-network",
+        ],
+        deps = [":selenium_manager"] + all_crate_deps(
+            normal = True,
+            normal_dev = True,
+        ),
+    )
+    for file in glob(["tests/**/*.rs"])
+]
diff --git a/rust/tests/cli_tests.rs b/rust/tests/cli_tests.rs
@@ -40,7 +40,7 @@ fn ok_test(
         browser, browser_version, driver_version
     );
 
-    let mut cmd = Command::cargo_bin(env!("CARGO_PKG_NAME")).unwrap();
+    let mut cmd = Command::new(env!("CARGO_BIN_EXE_selenium-manager"));
     cmd.args(["--browser", &browser, "--browser-version", &browser_version])
         .assert()
         .success()
@@ -78,7 +78,7 @@ fn error_test(
         browser, browser_version, driver_version
     );
 
-    let mut cmd = Command::cargo_bin(env!("CARGO_PKG_NAME")).unwrap();
+    let mut cmd = Command::new(env!("CARGO_BIN_EXE_selenium-manager"));
     cmd.args([
         "--browser",
         &browser,
@@ -99,7 +99,7 @@ fn error_test(
 fn beta_test(#[case] browser: String, #[case] driver_name: String) {
     println!("Beta test browser={browser} -- driver_name={driver_name}");
 
-    let mut cmd = Command::cargo_bin(env!("CARGO_PKG_NAME")).unwrap();
+    let mut cmd = Command::new(env!("CARGO_BIN_EXE_selenium-manager"));
     let assert = cmd
         .args(["--browser", &browser, "--browser-version", "beta"])
         .assert();
@@ -126,7 +126,7 @@ fn path_test(#[case] browser: String, #[case] browser_path: String) {
         browser, browser_path
     );
 
-    let mut cmd = Command::cargo_bin(env!("CARGO_PKG_NAME")).unwrap();
+    let mut cmd = Command::new(env!("CARGO_BIN_EXE_selenium-manager"));
     cmd.args(["--browser", &browser, "--browser-path", &browser_path])
         .assert()
         .success()
diff --git a/rust/tests/iexplorer_tests.rs b/rust/tests/iexplorer_tests.rs
@@ -23,7 +23,7 @@ use rstest::rstest;
 #[case("4.8.0")]
 #[case("4.8.1")]
 fn iexplorer_test(#[case] driver_version: String) {
-    let mut cmd = Command::cargo_bin(env!("CARGO_PKG_NAME")).unwrap();
+    let mut cmd = Command::new(env!("CARGO_BIN_EXE_selenium-manager"));
     let cmd_assert = cmd
         .args([
             "--browser",
@@ -43,7 +43,7 @@ fn iexplorer_test(#[case] driver_version: String) {
 #[case("internet-explorer")]
 #[case("internet_explorer")]
 fn ie_name_test(#[case] browser_name: String) {
-    let mut cmd = Command::cargo_bin(env!("CARGO_PKG_NAME")).unwrap();
+    let mut cmd = Command::new(env!("CARGO_BIN_EXE_selenium-manager"));
     let cmd_assert = cmd.args(["--browser", &browser_name]).assert();
     cmd_assert.success();
 }
diff --git a/rust/tests/output_tests.rs b/rust/tests/output_tests.rs
@@ -23,7 +23,7 @@ use std::str;
 
 #[test]
 fn json_output_test() {
-    let mut cmd = Command::cargo_bin(env!("CARGO_PKG_NAME")).unwrap();
+    let mut cmd = Command::new(env!("CARGO_BIN_EXE_selenium-manager"));
     cmd.args(["--browser", "chrome", "--output", "json"])
         .assert()
         .success()
@@ -45,7 +45,7 @@ fn json_output_test() {
 
 #[test]
 fn shell_output_test() {
-    let mut cmd = Command::cargo_bin(env!("CARGO_PKG_NAME")).unwrap();
+    let mut cmd = Command::new(env!("CARGO_BIN_EXE_selenium-manager"));
     cmd.args(["--browser", "chrome", "--output", "shell"])
         .assert()
         .success()
diff --git a/rust/tests/proxy_tests.rs b/rust/tests/proxy_tests.rs
@@ -24,7 +24,7 @@ use wiremock::MockServer;
 #[tokio::test]
 async fn ok_proxy_test() {
     let mock_server = MockServer::start().await;
-    let mut cmd = Command::cargo_bin(env!("CARGO_PKG_NAME")).unwrap();
+    let mut cmd = Command::new(env!("CARGO_BIN_EXE_selenium-manager"));
     cmd.args(["--browser", "chrome", "--proxy", &mock_server.uri()])
         .assert()
         .success()
@@ -33,7 +33,7 @@ async fn ok_proxy_test() {
 
 #[test]
 fn wrong_protocol_proxy_test() {
-    let mut cmd = Command::cargo_bin(env!("CARGO_PKG_NAME")).unwrap();
+    let mut cmd = Command::new(env!("CARGO_BIN_EXE_selenium-manager"));
     cmd.args(["--browser", "chrome", "--proxy", "wrong:://proxy"])
         .assert()
         .failure()
@@ -42,7 +42,7 @@ fn wrong_protocol_proxy_test() {
 
 #[test]
 fn wrong_port_proxy_test() {
-    let mut cmd = Command::cargo_bin(env!("CARGO_PKG_NAME")).unwrap();
+    let mut cmd = Command::new(env!("CARGO_BIN_EXE_selenium-manager"));
     cmd.args([
         "--browser",
         "chrome",
diff --git a/rust/tests/safari_tests.rs b/rust/tests/safari_tests.rs
@@ -20,7 +20,7 @@ use std::env::consts::OS;
 
 #[test]
 fn safari_test() {
-    let mut cmd = Command::cargo_bin(env!("CARGO_PKG_NAME")).unwrap();
+    let mut cmd = Command::new(env!("CARGO_BIN_EXE_selenium-manager"));
     let safari_assert = cmd.args(["--browser", "safari"]).assert();
 
     if OS.eq("macos") {
diff --git a/rust/tests/timeout_tests.rs b/rust/tests/timeout_tests.rs
@@ -21,7 +21,7 @@ use exitcode::DATAERR;
 
 #[test]
 fn timeout_proxy_test() {
-    let mut cmd = Command::cargo_bin(env!("CARGO_PKG_NAME")).unwrap();
+    let mut cmd = Command::new(env!("CARGO_BIN_EXE_selenium-manager"));
     cmd.args([
         "--clear-cache",
         "--debug",
