Skip to content

Commit 26978eb

Browse files
committed
[javascript] Patching rules closure to use shell env
Needed because macOS 12.3 removed /usr/bin/python and the rule was not looking for other options in the path. macOS users, for now, need to symlink python3 to python to keep building.
1 parent 8b48a74 commit 26978eb

2 files changed

Lines changed: 18 additions & 0 deletions

File tree

WORKSPACE

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -149,6 +149,12 @@ npm_install(
149149

150150
http_archive(
151151
name = "io_bazel_rules_closure",
152+
patch_args = [
153+
"-p1",
154+
],
155+
patches = [
156+
"//javascript:rules_closure_shell.patch",
157+
],
152158
sha256 = "d66deed38a0bb20581c15664f0ab62270af5940786855c7adc3087b27168b529",
153159
strip_prefix = "rules_closure-0.11.0",
154160
urls = [
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
diff --git a/closure/compiler/closure_js_deps.bzl b/closure/compiler/closure_js_deps.bzl
2+
index 197c621..6db3aa8 100644
3+
--- a/closure/compiler/closure_js_deps.bzl
4+
+++ b/closure/compiler/closure_js_deps.bzl
5+
@@ -52,6 +52,7 @@ def _impl(ctx):
6+
)
7+
]),
8+
executable = ctx.executable._depswriter,
9+
+ use_default_shell_env = True,
10+
progress_message = "Calculating %d JavaScript deps to %s" % (
11+
len(js.srcs.to_list()),
12+
ctx.outputs.out.short_path,

0 commit comments

Comments
 (0)