[java][bidi] Rename 'onConsoleLog' to 'onConsoleEntry'

pujagani · pujagani · commit 2443d5a31808 · 2022-12-19T14:53:50.000+05:30
Discussed in #11368 (comment)
diff --git a/java/src/org/openqa/selenium/bidi/LogInspector.java b/java/src/org/openqa/selenium/bidi/LogInspector.java
@@ -95,10 +95,15 @@ private void initializeLogListener() {
     }
   }
 
+  @Deprecated
   public void onConsoleLog(Consumer<ConsoleLogEntry> consumer) {
     consoleLogListeners.add(consumer);
   }
 
+  public void onConsoleEntry(Consumer<ConsoleLogEntry> consumer) {
+    consoleLogListeners.add(consumer);
+  }
+
   public void onJavaScriptLog(Consumer<JavascriptLogEntry> consumer) {
     jsLogListeners.add(consumer);
   }
diff --git a/java/test/org/openqa/selenium/bidi/LogInspectorTest.java b/java/test/org/openqa/selenium/bidi/LogInspectorTest.java
@@ -64,7 +64,7 @@ public void setUp() {
   void canListenToConsoleLog() throws ExecutionException, InterruptedException, TimeoutException {
     try (LogInspector logInspector = new LogInspector(driver)) {
       CompletableFuture<ConsoleLogEntry> future = new CompletableFuture<>();
-      logInspector.onConsoleLog(future::complete);
+      logInspector.onConsoleEntry(future::complete);
 
       page = server.whereIs("/bidi/logEntryAdded.html");
       driver.get(page);
@@ -148,7 +148,7 @@ void canListenToConsoleLogForABrowsingContext()
 
     try (LogInspector logInspector = new LogInspector(browsingContextId, driver)) {
       CompletableFuture<ConsoleLogEntry> future = new CompletableFuture<>();
-      logInspector.onConsoleLog(future::complete);
+      logInspector.onConsoleEntry(future::complete);
 
       driver.get(page);
       driver.findElement(By.id("consoleLog")).click();
@@ -224,7 +224,7 @@ void canListenToConsoleLogForMultipleBrowsingContexts()
     CountDownLatch latch = new CountDownLatch(2);
 
     try (LogInspector logInspector = new LogInspector(browsingContextIds, driver)) {
-      logInspector.onConsoleLog(logEntry -> latch.countDown());
+      logInspector.onConsoleEntry(logEntry -> latch.countDown());
 
       driver.get(page);
       // Triggers console event in the second tab

Original file line number	Diff line number	Diff line change
`@@ -95,10 +95,15 @@ private void initializeLogListener() {`
`95`	`95`	`}`
`96`	`96`	`}`
`97`	`97`
	`98`	`+ @Deprecated`
`98`	`99`	`public void onConsoleLog(Consumer<ConsoleLogEntry> consumer) {`
`99`	`100`	`consoleLogListeners.add(consumer);`
`100`	`101`	`}`
`101`	`102`
	`103`	`+ public void onConsoleEntry(Consumer<ConsoleLogEntry> consumer) {`
	`104`	`+ consoleLogListeners.add(consumer);`
	`105`	`+ }`
	`106`	`+`
`102`	`107`	`public void onJavaScriptLog(Consumer<JavascriptLogEntry> consumer) {`
`103`	`108`	`jsLogListeners.add(consumer);`
`104`	`109`	`}`