Remove "shadow_root" assertion in Python bindings for Firefox (#11821)

whimboo · diemol · web-flow · commit 1f8b0c5eb0cb · 2023-03-27T18:56:40.000+02:00
Remove "shadow_root" assertion for Firefox.

The "Get Element ShadowRoot" command has been implemented
in Firefox 96 (a year ago) and it should no longer cause
an assertion.

Co-authored-by: Diego Molina &lt;diemol@users.noreply.github.com&gt;
diff --git a/py/selenium/webdriver/remote/webelement.py b/py/selenium/webdriver/remote/webelement.py
@@ -235,21 +235,20 @@ def send_keys(self, *value) -> None:
     @property
     def shadow_root(self) -> ShadowRoot:
         """Returns a shadow root of the element if there is one or an error.
-        Only works from Chromium 96 onwards. Previous versions of Chromium
-        based browsers will throw an assertion exception.
+        Only works from Chromium 96 and Firefox 96 onwards. Previous versions
+        of browsers will throw an assertion exception.
 
         :Returns:
           - ShadowRoot object or
           - NoSuchShadowRoot - if no shadow root was attached to element
         """
         browser_main_version = int(self._parent.caps["browserVersion"].split(".")[0])
-        assert self._parent.caps["browserName"].lower() not in [
-            "firefox",
-            "safari",
-        ], "This only currently works in Chromium based browsers"
+        assert (
+            self._parent.caps["browserName"].lower() != "safari"
+        ), "This only currently works in Firefox and Chromium based browsers"
         assert (
             browser_main_version > 95
-        ), f"Please use Chromium based browsers with version 96 or later. Version used {self._parent.caps['browserVersion']}"
+        ), f"Please use Firefox or Chromium based browsers with version 96 or later. Version used {self._parent.caps['browserVersion']}"
         return self._execute(Command.GET_SHADOW_ROOT)["value"]
 
     # RenderedWebElement Items
diff --git a/py/test/selenium/webdriver/common/web_components_tests.py b/py/test/selenium/webdriver/common/web_components_tests.py
@@ -24,7 +24,6 @@
 
 
 @pytest.mark.xfail_safari
-@pytest.mark.xfail_firefox
 @pytest.mark.xfail_remote
 def test_can_get_the_shadow_root_of_an_element(driver, pages):
     pages.load("webComponents.html")
@@ -33,7 +32,6 @@ def test_can_get_the_shadow_root_of_an_element(driver, pages):
 
 
 @pytest.mark.xfail_safari
-@pytest.mark.xfail_firefox
 @pytest.mark.xfail_remote
 def test_no_such_shadow_root_thrown_when_no_shadow_root(driver, pages):
     with pytest.raises(NoSuchShadowRootException):
@@ -42,7 +40,6 @@ def test_no_such_shadow_root_thrown_when_no_shadow_root(driver, pages):
 
 
 @pytest.mark.xfail_safari
-@pytest.mark.xfail_firefox
 @pytest.mark.xfail_remote
 def test_returns_shadow_root_via_execute_script(driver, pages):
     pages.load("webComponents.html")
