[java] Remove connection timeout setter

pujagani · pujagani · commit 1990a43a7456 · 2022-01-13T17:17:43.000+05:30
Since the AsyncHttpClient is initialized using a static block and that uses the default client config values, any newly set value of connection timeout is never used.
diff --git a/java/src/org/openqa/selenium/remote/http/ClientConfig.java b/java/src/org/openqa/selenium/remote/http/ClientConfig.java
@@ -93,16 +93,6 @@ public URL baseUrl() {
     }
   }
 
-  public ClientConfig connectionTimeout(Duration timeout) {
-    return new ClientConfig(
-      baseUri,
-      Require.nonNull("Connection timeout", timeout),
-      readTimeout,
-      filters,
-      proxy,
-      credentials);
-  }
-
   public Duration connectionTimeout() {
     return connectionTimeout;
   }
diff --git a/java/test/org/openqa/selenium/remote/RemoteWebDriverBuilderTest.java b/java/test/org/openqa/selenium/remote/RemoteWebDriverBuilderTest.java
@@ -310,7 +310,6 @@ public void shouldSetRemoteHostUriOnClientConfigIfSet() {
   @Test
   public void shouldThrowErrorIfCustomConfigIfSetForLocalDriver() {
     ClientConfig config = ClientConfig.defaultConfig()
-      .connectionTimeout(Duration.ofMinutes(5))
       .readTimeout(Duration.ofMinutes(4));
 
     RemoteWebDriverBuilder builder = RemoteWebDriver.builder()

Original file line number	Diff line number	Diff line change
`@@ -93,16 +93,6 @@ public URL baseUrl() {`
`93`	`93`	`}`
`94`	`94`	`}`
`95`	`95`
`96`		`- public ClientConfig connectionTimeout(Duration timeout) {`
`97`		`- return new ClientConfig(`
`98`		`- baseUri,`
`99`		`- Require.nonNull("Connection timeout", timeout),`
`100`		`- readTimeout,`
`101`		`- filters,`
`102`		`- proxy,`
`103`		`- credentials);`
`104`		`- }`
`105`		`-`
`106`	`96`	`public Duration connectionTimeout() {`
`107`	`97`	`return connectionTimeout;`
`108`	`98`	`}`